Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting rid of old change logs #2145

Merged
merged 3 commits into from
Oct 30, 2017
Merged

getting rid of old change logs #2145

merged 3 commits into from
Oct 30, 2017

Conversation

danielduan
Copy link
Member

@danielduan danielduan commented Oct 28, 2017

Issue:
Old changelogs are confusing, fixes #1557

@danielduan danielduan added cleanup Minor cleanup style change that won't show up in release changelog documentation labels Oct 28, 2017
@codecov
Copy link

codecov bot commented Oct 28, 2017

Codecov Report

Merging #2145 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2145      +/-   ##
=========================================
- Coverage   21.43%   21.4%   -0.04%     
=========================================
  Files         263     263              
  Lines        5803    5812       +9     
  Branches      686     693       +7     
=========================================
  Hits         1244    1244              
+ Misses       4047    4040       -7     
- Partials      512     528      +16
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
addons/info/src/components/PropTable.js 21% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 49.01% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 29.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.97% <0%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0e4ac...9527f5c. Read the comment docs.

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shilman do you agree?

@danielduan danielduan merged commit 7709161 into master Oct 30, 2017
@danielduan danielduan deleted the dd/changelo branch October 30, 2017 15:03
@danielduan
Copy link
Member Author

I'm just gonna merge this so we can close the PR. If you'd like it back, just hit the revert button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants