-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack5: Add lazy compilation #17501
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit 3052b90. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
4f94e71
to
a8796f4
Compare
As it conflicts with lazy compilation
@shilman I am going to investigate the third point on a separate time-scale, I think this is good to merge. |
@@ -32,6 +32,7 @@ export interface Webpack5BuilderConfig extends BuilderConfigObject { | |||
name: 'webpack5'; | |||
options?: { | |||
fsCache?: boolean; | |||
lazyCompilation?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to document this somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a separate ticket to do this, do you want to hold the PR for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @tmeasday!! 🚀
What I did
Add
builderOptions.lazyCompilation
to allow users to opt-into webpack's lazy compilation experiment.NOTE: this disables the "entry" compilation, as otherwise that just needs to be compiled straight away when the user visits the SB anyway.
TODO
How to test