Replace Emotion theme context with a custom context implementation

[fabian-hiller]

Issue: #10231 (comment)

What I did

I have added a custom context to the storybook theming package and replaced the previous emotion apis or rewritten it to use the new context.

How to test

I have started a storybook from the examples directory to check if there are errors in the console. I am open for further tests.

• Is this testable with Jest or Chromatic screenshots? - No
• Does this need a new example in the kitchen sink apps? - No
• Does this need an update to the documentation? - No

Notes

Please have a look at my code and add improvements if necessary.

Credits

• Thanks to @ndelangen for the introduction to Storybook
• Thanks to @connor-baer for the helpful code example

[ndelangen]

Thanks for taking this on @fabian-hiller this is not an easy task. 🙏

[ndelangen]

I've fixed a few TS typings, but I there are more. Perhaps you could investigate if you could improve the typings of styled somehow?

[ndelangen]

Actually it's currently withTheme that seems to have incorrect typings.

storybook/lib/theming/src/with-theme.tsx

Line 4 in be71286

export const withTheme = (Component: any) => {

[fabian-hiller]

I've fixed a few TS typings, but I there are more. Perhaps you could investigate if you could improve the typings of styled somehow?

I don't have too much experience with TypeScript yet, so I think it's better if someone else does it.

[connor-baer]

I'd love to see this merged in Storybook 6.

@mrmckeb + @ndelangen, I see that you tried to fix the types but based on the test failures I can't tell if you succeeded. Is there anything left to do, something I could help with?

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[javialon26]

any news on this?

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[stale]

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

[connor-baer]

Now that Storybook 6 is out, is this something that can be tackled in a minor release? Or do we need to wait until v7?