Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install with engine-strict #3029

Closed
felixfbecker opened this issue Feb 19, 2018 · 4 comments
Closed

Can't install with engine-strict #3029

felixfbecker opened this issue Feb 19, 2018 · 4 comments

Comments

@felixfbecker
Copy link

felixfbecker commented Feb 19, 2018

Runnning npm install @storybook/react --engine-strict (or with engine-strict in .npmrc) with npm 5 fails with

npm ERR! code ENOTSUP
npm ERR! notsup Unsupported engine for [email protected]: wanted: {"npm":"^3.0.0"} (current: {"node":"8.9.1","npm":"5.6.0"})
npm ERR! notsup Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Required: {"npm":"^3.0.0"}
npm ERR! notsup Actual:   {"npm":"5.6.0","node":"8.9.1"}

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/felix/.npm/_logs/2018-02-19T22_21_14_142Z-debug.log

Afaik yarn has this on by default too.

Dependency tree:

[email protected] /Users/felix/go/src/sourcegraph.com/sourcegraph/sourcegraph/web
└─┬ @storybook/[email protected]
  └─┬ @storybook/[email protected]
    └── [email protected]

Tracked in arunoda/podda#6, but obviously severely impacting storybook.
PR has been open since August: arunoda/podda#5

@Hypnosphi
Copy link
Member

Hypnosphi commented Feb 19, 2018

Related: #2313

@danielduan can we integrate arunoda/podda#5 into our fork?

@danielduan
Copy link
Member

danielduan commented Feb 20, 2018

yeah, looks relatively harmless. I'll grab that branch and push it.

we should think about how to go about refactoring and getting rid of podda though.

@Hypnosphi
Copy link
Member

I'd base on ideas from #1334

Hypnosphi added a commit that referenced this issue Feb 20, 2018
#3029 use @storybook/podda to fix npm engine version in podda
@Hypnosphi
Copy link
Member

Released 3.3.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants