Confusing warning: "…simply add @storybook/preset-create-react-app to your project."

[techieshark]

Describe the bug

After upgrading to Storybook 5.3.17, I ran 'yarn storybook' and see the following warning:

WARN Storybook support for Create React App is now a separate preset.
WARN To get started with the new preset, simply add `@storybook/preset-create-react-app` to your project.
WARN The built-in preset will be disabled in Storybook 6.0.

This is confusing, because I have "@storybook/preset-create-react-app" in my package.json.

To Reproduce
Steps to reproduce the behavior:

1. Create storybook react project or upgrade one to 5.3.17.
2. Run 'yarn start-storybook`.
3. Observe warning.

Expected behavior

A warning explaining more than "simply add @storybook/preset-create-react-app to your project.'".

(Sidenote: searching the codebase for 'simply add', I ran across "simply add" as an example of "bad documentation").

I was confused for quite a while because I thought I needed to only add it to package.json.

It seems I actually am supposed to add it to the list of addons in ./storybook/main.js:

module.exports = {
  stories: ['../**/*.stories.js'],
  addons:
  [
    '@storybook/preset-create-react-app',
  ...
 ]

(Adding it has made the warning go away.)

Screenshots

Code snippets
Appears the message comes from here:

storybook/app/react/src/server/framework-preset-cra.ts

Line 18 in 7ba88f6

'To get started with the new preset, simply add `@storybook/preset-create-react-app` to your project.'

[shilman]

@techieshark any chance you can contribute a PR to fix it?

[techieshark]

@shilman yep done! Thanks : )

[jeremyzilar]

Do you need to add @storybook/preset-create-react-app to your project even if you're not using create react app?

[umarmw]

@jeremyzilar, the same question that I'm asking as it makes no sense to me.

[its-miller-time]

+1 for @jeremyzilar quesion