Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint: Create necessary files #3

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

billpull
Copy link
Contributor

Right now in the Storybook docs for ember it states

Your environment will be preconfigured using ember-cli-storybook. This will add a preview-head.html, a .env and make sure that your environment is configured to work with live reload.

Found this confusing since running the example storybook commands after this install failed on finding preview-head.html.

Also I think it would be good if, as #1 suggests, this was a standalone install. People within the ember community are used to running ember install <addon-name> without the prereq of installing @storybook/ember separately. I included that as an afterInstall dep with the hope that part of the docs can be removed.

Not an expert on testing addons from forks so this may need some help from others.

@deanmraz
Copy link

@billpull thanks!

@gabrielcsapo this worked for me, can we get this installed for others? Probably should update https://storybook.js.org/basics/guide-ember/ once you do. It can be as easy as just running:

$ ember install ember-cli-storybook

Then all the files and dependencies will get added for the dev.

@gabrielcsapo gabrielcsapo merged commit e11eee7 into storybookjs:master Feb 5, 2019
@gabrielcsapo
Copy link
Collaborator

Awesome! thanks guys, been a little busy, I will bump this and make a PR for storybook to update docs.

@billpull billpull deleted the generate-default-files branch February 5, 2019 17:25
gabrielcsapo added a commit that referenced this pull request Feb 5, 2019
- [enables blueprints](#3)
@gabrielcsapo
Copy link
Collaborator

Published in 0.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants