New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Spinner accessibility #55

Merged

domyen merged 1 commit into master from jsomsanith/fix/spinner_a11y

Jul 9, 2019

Contributor

jsomsanith commented Jul 3, 2019

What is the problem this PR is trying to solve?
Spinner component is not accessible, this PR fixes the same issues as ProgressDot (#45)

no text alternative.
a loader should be a live region so SR announce any change after loading.

What is the chosen solution to this problem?

set an aria-label.
this component is used to load subparts of the page. It should not be an assertive region or it can be a hell for screen readers. Set aria-live to polite and role to status.


          fix: Spinner accessibility

c64d47f

domyen merged commit 25f9cd2 into master

domyen deleted the jsomsanith/fix/spinner_a11y branch

July 9, 2019 13:36

Member

domyen commented Jul 11, 2019

🚀 PR was released in v0.0.42 🚀

domyen added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels