Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spacing with integers #43

Closed
johannes-lindgren opened this issue Jan 3, 2025 · 0 comments
Closed

spacing with integers #43

johannes-lindgren opened this issue Jan 3, 2025 · 0 comments

Comments

@johannes-lindgren
Copy link
Collaborator

In the theme spacing functions, use the Math.floor or Math.ceil to round all floating point numbers to integers, so that the spacing cannot be used incorrectly with non-integers.
marcosh-ramos added a commit that referenced this issue Jan 13, 2025
@marcosh-ramos
chore: changing mui theme spacing
c841b5e 
- decreasing the spacing size from 5 to 4: Closes [#43](#43)
- round down floating point numbers: Closes [#33](#33)
marcosh-ramos added a commit that referenced this issue Jan 13, 2025
@marcosh-ramos
chore: changing mui theme spacing
bc430bd 
- decreasing the spacing size from 5 to 4: Closes #43
- round down floating point numbers: Closes #33
@marcosh-ramos marcosh-ramos mentioned this issue Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcosh-ramos @johannes-lindgren