Update: Remove eslint-plugin-prettier extends (#261)

.changeset/violet-chairs-kneel.md

@@ -0,0 +1,9 @@
+---
+'@zazen/eslint-config': minor
+---
+
+Remove `eslint-plugin-prettier` from extended rulesets
+
+Per [Prettier’s integration recommendations](https://prettier.io/docs/en/integrating-with-linters.html), Prettier is run separately from
+ESLint. Should update `lint-staged` config to include `prettier --write` for
+appropriate files.

README.md

@@ -65,7 +65,7 @@ Removed for now until/unless I get more opinionated about Vue code. For now, ins
     extends: [
         'plugin:vue/[vue3-]recommended',
         '@zazen',
-        'plugin:prettier/recommended',
+        'prettier',
     ],
     rules: { /* … */ },
 }

index.js

@@ -17,14 +17,14 @@ module.exports = {
      * @see https://github.com/sindresorhus/eslint-plugin-unicorn
      * @see https://github.com/import-js/eslint-plugin-import
      * @see https://github.com/xjamundx/eslint-plugin-promise
-     * @see https://github.com/prettier/eslint-plugin-prettier
+     * @see https://github.com/prettier/eslint-config-prettier
      */
     extends: [
         'xo',
         'plugin:unicorn/recommended',
         'plugin:import/recommended',
         'plugin:promise/recommended',
-        'plugin:prettier/recommended',
+        'prettier',
     ],
     rules: {
         'no-console': 'warn',

node.js

@@ -5,7 +5,7 @@ module.exports = {
     /**
      * @see https://github.com/weiran-zsd/eslint-plugin-node
      */
-    extends: ['plugin:prettier/recommended'],
+    extends: ['prettier'],
     rules: {
         /**
          * We have this enabled in addition to `import/extensions` as

package.json

@@ -17,14 +17,16 @@
   ],
   "scripts": {
     "changeset": "changeset add",
-    "eslint-check": "eslint --print-config . | eslint-config-prettier-check",
     "lint": "eslint .",
     "prepare": "husky install",
     "release": "changeset publish",
     "test": "ava"
   },
   "lint-staged": {
-    "*.{js,cjs,mjs}": "eslint --fix",
+    "*.{js,cjs,mjs}": [
+      "eslint --fix",
+      "prettier --write"
+    ],
     "package.json": "prettier --write"
   },
   "prettier": {
@@ -42,7 +44,6 @@
     "eslint-plugin-import": "2.25.4",
     "eslint-plugin-n": "14.0.0",
     "eslint-plugin-prefer-let": "3.0.1",
-    "eslint-plugin-prettier": "4.0.0",
     "eslint-plugin-promise": "6.0.0",
     "eslint-plugin-unicorn": "40.1.0"
   },

typescript.js

@@ -5,11 +5,7 @@ module.exports = {
      * @see https://github.com/xojs/eslint-config-xo-typescript
      * @see https://github.com/cartant/eslint-plugin-etc
      */
-    extends: [
-        'xo-typescript',
-        'plugin:etc/recommended',
-        'plugin:prettier/recommended',
-    ],
+    extends: ['xo-typescript', 'plugin:etc/recommended', 'prettier'],
     rules: {
         'import/named': 'off',