Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine property grouping #382

Merged
merged 19 commits into from
Jan 17, 2025
Merged

Refine property grouping #382

merged 19 commits into from
Jan 17, 2025

Conversation

stormwarning
Copy link
Owner

@stormwarning stormwarning commented Sep 1, 2024

The updated grouping keeps most properties in the same order as before, just a bit more organised. However, there are a few changes to the order, particularly

  • text-overflow-* (now grouped with overflow)
  • text-decoration-* (now grouped after basic text properties)
  • list-style-* (now grouped after text properties)
  • outline-* (now grouped before backgrounds and borders)
  • transition-* (now grouped after transform)
Diff of changes to all currently sorted properties
'composes',
'all',
'position',
'inset',
'inset-block',
'inset-block-start',
'inset-block-end',
'inset-inline',
'inset-inline-start',
'inset-inline-end',
'top',
'right',
'bottom',
'left',
'z-index',
+ 'float',
+ 'clear',
'box-sizing',
'display',
+ 'visibility',
'flex',
'flex-basis',
'flex-direction',
'flex-flow',
'flex-grow',
'flex-shrink',
'flex-wrap',
'-webkit-box-orient',
'grid',
'grid-area',
'grid-template',
'grid-template-areas',
'grid-template-rows',
'grid-template-columns',
'grid-row',
'grid-row-start',
'grid-row-end',
'grid-column',
'grid-column-start',
'grid-column-end',
'grid-auto-rows',
'grid-auto-columns',
'grid-auto-flow',
'grid-gap',
'grid-row-gap',
'grid-column-gap',
'gap',
'row-gap',
'column-gap',
'place-content',
'place-items',
'place-self',
'align-content',
'align-items',
'align-self',
'justify-content',
'justify-items',
'justify-self',
'order',
- 'float',
'inline-size',
'min-inline-size',
'max-inline-size',
'width',
'min-width',
'max-width',
'block-size',
'min-block-size',
'max-block-size',
'height',
'min-height',
'max-height',
'aspect-ratio',
'padding',
'padding-block',
'padding-block-start',
'padding-block-end',
'padding-inline',
'padding-inline-start',
'padding-inline-end',
'padding-top',
'padding-right',
'padding-bottom',
'padding-left',
'margin',
'margin-block',
'margin-block-start',
'margin-block-end',
'margin-inline',
'margin-inline-start',
'margin-inline-end',
'margin-top',
'margin-right',
'margin-bottom',
'margin-left',
'overflow',
'overflow-block',
'overflow-inline',
'overflow-x',
'overflow-y',
'-webkit-overflow-scrolling',
'-ms-overflow-x',
'-ms-overflow-y',
'-ms-overflow-style',
+ 'text-overflow',
+ 'text-overflow-ellipsis',
+ 'text-overflow-mode',
+ '-webkit-line-clamp',
+ 'line-clamp',
+ 'scroll-behaviour',
'overscroll-behavior',
'overscroll-behavior-inline',
'overscroll-behavior-block',
'overscroll-behavior-x',
'overscroll-behavior-y',
- 'clip',
- 'clip-path',
- 'clear',
'font',
'font-family',
'font-size',
'font-variation-settings',
'font-style',
'font-weight',
'font-feature-settings',
'font-optical-sizing',
'font-kerning',
'font-variant',
'font-variant-ligatures',
'font-variant-caps',
'font-variant-alternates',
'font-variant-numeric',
'font-variant-east-asian',
'font-variant-position',
'font-size-adjust',
'font-stretch',
'font-effect',
'font-emphasize',
'font-emphasize-position',
'font-emphasize-style',
'-webkit-font-smoothing',
'-moz-osx-font-smoothing',
'font-smooth',
- 'hyphens',
'line-height',
'color',
'-webkit-text-fill-color',
'-webkit-text-stroke',
'-webkit-text-stroke-width',
'-webkit-text-stroke-color',
+ 'hyphens',
'text-align',
'text-align-last',
- 'text-emphasis',
- 'text-emphasis-color',
- 'text-emphasis-style',
- 'text-emphasis-position',
- 'text-decoration',
- 'text-decoration-line',
- 'text-decoration-thickness',
- 'text-decoration-style',
- 'text-decoration-color',
- 'text-underline-position',
- 'text-underline-offset',
'text-indent',
'text-justify',
'text-outline',
- 'text-overflow',
- 'text-overflow-ellipsis',
- 'text-overflow-mode',
- '-webkit-line-clamp',
- 'line-clamp',
- 'text-shadow',
'text-transform',
'text-wrap',
'-webkit-text-size-adjust',
'-ms-text-size-adjust',
'letter-spacing',
'word-break',
'word-spacing',
'word-wrap',
'overflow-wrap',
'tab-size',
'white-space',
'vertical-align',
- 'list-style',
- 'list-style-position',
- 'list-style-type',
- 'list-style-image',
+ 'text-emphasis',
+ 'text-emphasis-color',
+ 'text-emphasis-style',
+ 'text-emphasis-position',
+ 'text-decoration',
+ 'text-decoration-line',
+ 'text-decoration-thickness',
+ 'text-decoration-style',
+ 'text-decoration-color',
+ 'text-underline-position',
+ 'text-underline-offset',
+ 'text-shadow',
'src',
'font-display',
'unicode-range',
'size-adjust',
'ascent-override',
'descent-override',
'line-gap-override',
'appearance',
'accent-color',
- 'color-scheme',
'pointer-events',
'-ms-touch-action',
'touch-action',
'cursor',
'caret-color',
- 'visibility',
'zoom',
+ 'resize',
+ 'user-select',
+ '-webkit-user-select',
+ 'nav-index',
+ 'nav-up',
+ 'nav-right',
+ 'nav-down',
+ 'nav-left',
+ 'outline',
+ 'outline-width',
+ 'outline-style',
+ 'outline-color',
+ 'outline-offset',
+ 'color-scheme',
'table-layout',
'empty-cells',
'caption-side',
'border-spacing',
'border-collapse',
'content',
'quotes',
+ 'list-style',
+ 'list-style-position',
+ 'list-style-type',
+ 'list-style-image',
'counter-reset',
'counter-set',
'counter-increment',
- 'resize',
- 'scroll-behaviour',
'scroll-snap-type',
'scroll-snap-align',
'scroll-snap-stop',
'scroll-padding',
'scroll-padding-inline',
'scroll-padding-inline-start',
'scroll-padding-inline-end',
'scroll-padding-block',
'scroll-padding-block-start',
'scroll-padding-block-end',
'scroll-padding-top',
'scroll-padding-right',
'scroll-padding-bottom',
'scroll-padding-left',
'scroll-margin',
'scroll-margin-inline',
'scroll-margin-inline-start',
'scroll-margin-inline-end',
'scroll-margin-block',
'scroll-margin-block-start',
'scroll-margin-block-end',
'scroll-margin-top',
'scroll-margin-right',
'scroll-margin-bottom',
'scroll-margin-left',
'scrollbar-color',
'scrollbar-gutter',
'scrollbar-width',
- 'user-select',
- '-webkit-user-select',
- 'nav-index',
- 'nav-up',
- 'nav-right',
- 'nav-down',
- 'nav-left',
'object-fit',
'object-position',
'-ms-interpolation-mode',
'image-orientation',
'image-rendering',
'image-resolution',
'background',
'background-color',
'background-image',
"-ms-filter:\\'progid:DXImageTransform.Microsoft.gradient",
'filter:progid:DXImageTransform.Microsoft.gradient',
'filter:progid:DXImageTransform.Microsoft.AlphaImageLoader',
- 'filter',
'background-repeat',
'background-attachment',
'background-position',
'background-position-x',
'background-position-y',
'background-clip',
'background-origin',
'background-size',
- 'background-blend-mode',
- 'isolation',
- 'backdrop-filter',
'border',
'border-color',
'border-style',
'border-width',
'border-block',
'border-block-start',
'border-block-start-color',
'border-block-start-style',
'border-block-start-width',
'border-block-end',
'border-block-end-color',
'border-block-end-style',
'border-block-end-width',
'border-inline',
'border-inline-start',
'border-inline-start-color',
'border-inline-start-style',
'border-inline-start-width',
'border-inline-end',
'border-inline-end-color',
'border-inline-end-style',
'border-inline-end-width',
'border-top',
'border-top-color',
'border-top-style',
'border-top-width',
'border-right',
'border-right-color',
'border-right-style',
'border-right-width',
'border-bottom',
'border-bottom-color',
'border-bottom-style',
'border-bottom-width',
'border-left',
'border-left-color',
'border-left-style',
'border-left-width',
'border-radius',
'border-start-start-radius',
'border-start-end-radius',
'border-end-start-radius',
'border-end-end-radius',
'border-top-left-radius',
'border-top-right-radius',
'border-bottom-right-radius',
'border-bottom-left-radius',
'border-image',
'border-image-source',
'border-image-slice',
'border-image-width',
'border-image-outset',
'border-image-repeat',
- 'outline',
- 'outline-width',
- 'outline-style',
- 'outline-color',
- 'outline-offset',
'box-shadow',
+ 'background-blend-mode',
+ 'isolation',
'mix-blend-mode',
'filter:progid:DXImageTransform.Microsoft.Alpha(Opacity',
"-ms-filter:\\'progid:DXImageTransform.Microsoft.Alpha",
'opacity',
+ 'filter',
+ 'backdrop-filter',
+ 'clip',
+ 'clip-path',
'mask-border',
'mask-border-source',
'mask-border-slice',
'mask-border-width',
'mask-border-outset',
'mask-border-repeat',
'mask-border-mode',
'mask',
'mask-image',
'mask-mode',
'mask-repeat',
'mask-position',
'mask-clip',
'mask-origin',
'mask-size',
'mask-composite',
+ 'writing-mode',
'alignment-baseline',
'baseline-shift',
'dominant-baseline',
'text-anchor',
- 'word-spacing',
- 'writing-mode',
'fill',
'fill-opacity',
'fill-rule',
'stroke',
'stroke-dasharray',
'stroke-dashoffset',
'stroke-linecap',
'stroke-linejoin',
'stroke-miterlimit',
'stroke-opacity',
'stroke-width',
'color-interpolation',
'color-interpolation-filters',
'color-profile',
'color-rendering',
'flood-color',
'flood-opacity',
'lighting-color',
'marker-start',
'marker-mid',
'marker-end',
'shape-rendering',
'stop-color',
'stop-opacity',
- 'transition',
- 'transition-delay',
- 'transition-timing-function',
- 'transition-duration',
- 'transition-property',
'transform',
'transform-origin',
'rotate',
'scale',
'translate',
'perspective',
'perspective-origin',
+ 'transition',
+ 'transition-delay',
+ 'transition-timing-function',
+ 'transition-duration',
+ 'transition-property',
'animation',
'animation-name',
'animation-duration',
'transition-property',
'animation',
'animation-name',
'animation-duration',
'animation-play-state',
'animation-timing-function',
'animation-delay',
'animation-iteration-count',
'animation-direction',
'will-change',
'break-before',
'break-inside',
'break-after',
'orphans',
'widows',

The updated groups.js includes some placeholder comments for upcoming groups which gives these changes some additional context.

Not adding any new properties in this version in order to make the changes to the order easier to track/notice.

See #381

Copy link

changeset-bot bot commented Sep 1, 2024

🦋 Changeset detected

Latest commit: 05dfb0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint-config-recess-order Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stormwarning stormwarning marked this pull request as ready for review January 17, 2025 17:09
@stormwarning stormwarning merged commit 28d7eba into main Jan 17, 2025
1 check passed
@stormwarning stormwarning deleted the refine-grouping branch January 17, 2025 17:14
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant