[MAJOR] avoid incorrect default directory on iOS/macOS #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brody4hire
changed the title
- to be extra safe (see <#907>) - ensure that default "nosync" directory *always* has resource value set for `NSURLIsExcludedFromBackupKey` - add more checks for missing database directory
brody4hire
force-pushed
the
avoid-incorrect-default-directory-on-ios-macos
branch
from
e9b5a97 to
9afb77a
Compare
|
FYI I encountered a strange bug on the GitHub webpage here: https://github.jparrowsec.cnmunity/t5/Project-Development-Help-and/refreshed-PR-thinks-I-want-to-do-a-squash-merge/m-p/49890#M4982 I think this is a low-priority issue but thought it would be good to report and track to be fixed someday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure that default "nosync" directory always has resource value set for
NSURLIsExcludedFromBackupKey(to be extra-safe)
resolves #907