upgrade to cordova-ios 4.0

[andyverbunt]

Please upgrade the cordova-sqlite-storage plugin so it supports cordova-ios 4.0

The new cordova version finally supports WKWebView which has much better performance.
Unfortunately, there are breaking changes in the API which means all plugins need to upgrade.

Please check: https://shazronatadobe.wordpress.com/

[brody4hire]

This is because they quietly removed Cordova/NSData+Base64.h. This is not the first time they have broken plugins like this. I will raise a bug on Cordova.

[brody4hire]

I just filed https://issues.apache.org/jira/browse/CB-9638.

[andyverbunt]

Hi Chris,

Do you mean that this is the only breaking change regarding your plugin?
Have you looked at the API changes here?
https://github.com/apache/cordova-ios/blob/master/guides/API%20changes%20in%204.0.md

Thanks,
Andy

On Thu, 10 Sep 2015 at 16:34 Chris Brody [email protected] wrote:

This is because they quietly removed Cordova/NSData+Base64.h. This is not
the first time they have broken plugins like this. I will raise a bug on
Cordova.

—
Reply to this email directly or view it on GitHub
#338 (comment)
.

[brody4hire]

Do you mean that this is the only breaking change regarding your plugin?

Yes, and I am about to disable it.

Have you looked at the API changes here?
https://github.com/apache/cordova-ios/blob/master/guides/API%20changes%20in%204.0.md

Thanks, none of those changes affect this plugin.

[brody4hire]

Just fixed to build with cordova-ios 4.0, please close if it works for you.

[andyverbunt]

It compiles :)
Unfortunately I cannot easily test it because I have other plugins in my app that are not yet compatible with the new API.

Can you confirm that the compilation has a lot of warnings like these?

/platforms/ios/HelloCordova/Plugins/io.litehelpers.cordova.sqlite/sqlite3.c:105127:24: warning: ambiguous expansion of macro 'MAX'
      [-Wambiguous-macro]
        pParse->nMem = MAX(pParse->nMem, 8+j);

[brody4hire]

Yes, unfortunately. Ideally, we should add the compilations flags to plugin.xml to suppress these warnings on sqlite3.c.

[andyverbunt]

Just checking ;)

Anyways, thanks for the lightning fast response.
I'll close the issue.

[bhumikapathak]

You can find solution on my blog post. http://phonegapcmsworld.blogspot.in/2016/06/warning-sqlite3c-ambiguous-expansion-of.html

Solution: add “-Wno-ambiguous-macro” into “Other C flags”
Add flag to fix all warning related to Ambiguous expansion of macro.

[RyanTully]

Hello Chris,

I'm using sql-cipher-adapter and seeing three warnings in Xcode related to sqlite3.c. If I understand correctly from the above comments, can these be ignored?

Lexical or Preprocessor Issue

• Ambiguous expansion of macro 'MAX'
• Ambiguous expansion of macro 'MIN'

User Defined Issue

• "gethostuuid() is disabled."

Unused Entity Issue

• Unused function 'sqlite3PagerState'

Using:
cordova-sqlcipher-adapter 0.1.9
cordova 6.5.0
cordova ios 4.3.1
Xcode 8.3.2

Thanks

Ryan