feat: use new ucanto allows api for canDelegateCapability and implement space registration
#539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f4ad371.
gobengo
changed the title
…lement-access-authorize-in-agent-new-ucanto
gobengo
added a commit
that referenced
this pull request
Mar 15, 2023
Motivation: * do the upgrade so that we can merge #539 after (which requires the upgrade)
Motivation: * do the upgrade so that we can merge #539 after (which requires the upgrade)
…lement-access-authorize-in-agent-new-ucanto
travis
changed the title
canDelegateCapability
travis
changed the title
canDelegateCapabilitycanDelegateCapability and implement space registration
gobengo
reviewed
Mar 15, 2023
packages/access-client/src/agent.js
Outdated
| * @param {Ucanto.Principal<Ucanto.DID<'key'>>} device | ||
| */ | ||
| async function createSpaceSaysDeviceCanAccessDelegateWithSpace(space, device) { | ||
| async function createSpaceSaysDeviceCanAccessDelegateWithSpace( |
There was a problem hiding this comment.
may want to call this function now/soon createIssuerSays... since the authorization will now no longer always be from Space.
gobengo
reviewed
Mar 15, 2023
packages/access-client/src/agent.js
Outdated
| }, | ||
| }) | ||
| } | ||
|
|
||
| /** | ||
| * | ||
| * @param {Signer.EdSigner} space - TODO is this type correct? | ||
| * @param {Ucanto.DID} space - TODO is this type correct? |
There was a problem hiding this comment.
this can be Ucanto.DID<'key'> but also can change after merge
gobengo
reviewed
Mar 15, 2023
| canDelegateAbility(parent.can, child.can) | ||
| ) { | ||
| return true | ||
| // @ts-ignore ignore this until we bring in ucanto as a normal dependency rather than linking to a local version |
There was a problem hiding this comment.
We should be able to remove this right?
gobengo
reviewed
Mar 15, 2023
gobengo
approved these changes
Mar 15, 2023
gobengo
added a commit
that referenced
this pull request
Apr 11, 2023
Motivation: * do the upgrade so that we can merge #539 after (which requires the upgrade)
gobengo
added a commit
that referenced
this pull request
Apr 11, 2023
…ment space registration (#539) * use the new `allows` function in `ucanto` to reimplemeent `canDelegateCapability` * move space registration from `newCreateSpace` to `registerSpace` where it belongs * use agent's current account in registerSpace rather than requiring an email --------- Co-authored-by: Benjamin Goering <[email protected]>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [5.0.0](storacha/w3ui@keyring-core-v4.2.0...keyring-core-v5.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([storacha#530](storacha/w3ui#530)) ### Features * upgrade access client, ucanto and other packages ([storacha#530](storacha/w3ui#530)) ([8e7321b](storacha/w3ui@8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [5.0.0](storacha/w3ui@keyring-core-v4.2.0...keyring-core-v5.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([storacha#530](storacha/w3ui#530)) ### Features * upgrade access client, ucanto and other packages ([storacha#530](storacha/w3ui#530)) ([4449018](storacha/w3ui@4449018)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowsfunction inucantoto reimplemeentcanDelegateCapabilitynewCreateSpacetoregisterSpacewhere it belongs