Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: includes proofs chains in the delegated authorization chain #467

Merged
merged 6 commits into from
Mar 3, 2023
Merged

feat: includes proofs chains in the delegated authorization chain #467

merged 6 commits into from
Mar 3, 2023

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Mar 2, 2023 •
edited
Loading

This pr cleans up bunch of mess in the access/authorize code path and starts including proof chains in the delegated authorization so agents can actually utilize delegations.

@Gozala Gozala force-pushed the feat/bette-auth branch from c5c77bc to 8817ba4 Compare March 2, 2023 05:14
@Gozala Gozala changed the title feat: cleaupt authorization code feat: includes proofs chains in the delegated authorization chain Mar 2, 2023
@Gozala Gozala temporarily deployed to dev March 2, 2023 06:14 — with GitHub Actions Inactive
@Gozala Gozala requested review from gobengo and alanshaw March 2, 2023 06:16
@heyjay44 heyjay44 added this to the w3up phase 3 milestone Mar 2, 2023
gobengo
gobengo reviewed Mar 2, 2023
View reviewed changes
packages/access-api/src/service/index.js
@@ -31,7 +31,7 @@ export function service(ctx) {
claim: (...args) => {
// disable until hardened in test/staging
if (ctx.config.ENV === 'production') {
throw new Error(`acccess/claim invocation handling is not enabled`)
throw new Error(`access/claim invocation handling is not enabled`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing my typo :)

gobengo
gobengo reviewed Mar 2, 2023
View reviewed changes
packages/access-api/test/helpers/ucanto-test-utils.js
* @param {Ucanto.Signer<Ucanto.DID>} issuer
* @param {Ucanto.ConnectionView<Record<string, any>>} conn
* @param {object} options
* @param {Ucanto.Signer<Ucanto.DID>} options.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future I expect to have spaceRegistrationInvocation create a provider/add issued by an agent (not the 'service'), which is why I called it the more generic issuer. I can always change it back if/when we use non-service-issuers for this.

@gobengo gobengo merged commit 5144293 into main Mar 3, 2023
@gobengo gobengo deleted the feat/bette-auth branch March 3, 2023 00:11
This was referenced Mar 3, 2023
Closed
Merged
gobengo pushed a commit that referenced this pull request Mar 4, 2023
@it-dag-house
chore(main): release capabilities 3.1.0 (#470)
3b3a391 
🤖 I have created a release *beep* *boop*
---


##
[3.1.0](capabilities-v3.0.0...capabilities-v3.1.0)
(2023-03-04)


### Features

* access-api handles provider/add invocations
([#462](#462))
([5fb56f7](5fb56f7))
* includes proofs chains in the delegated authorization chain
([#467](#467))
([5144293](5144293))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Mar 21, 2023
Closed
Merged
alanshaw pushed a commit that referenced this pull request Mar 23, 2023
@it-dag-house
chore(main): release access-api 5.0.0 (#588)
c0fb10a 
🤖 I have created a release *beep* *boop*
---


##
[5.0.0](access-api-v4.11.0...access-api-v5.0.0)
(2023-03-23)


### ⚠ BREAKING CHANGES

* implement new account-based multi-device flow
([#433](#433))
* upgrade capabilities to latest ucanto
([#463](#463))

### Features

* access-api handles provider/add invocations
([#462](#462))
([5fb56f7](5fb56f7))
* access-api serves access/claim invocations
([#456](#456))
([baacf35](baacf35))
* access/authorize confirmation email click results in a delegation back
to the issuer did:key so that access/claim works
([#460](#460))
([a466a7d](a466a7d))
* allow multiple providers
([#595](#595))
([96c5a2e](96c5a2e))
* define `access/confirm` handler and use it in ucanto-test-utils
registerSpaces + validate-email handler
([#530](#530))
([b1bbc90](b1bbc90))
* handle access/delegate invocations without error
([#427](#427))
([4f0bd1c](4f0bd1c))
* if POST /validate-email?mode=authorize catches error w/ too big qr
code ([#516](#516))
([d0df525](d0df525))
* implement new account-based multi-device flow
([#433](#433))
([1ddc6a0](1ddc6a0))
* includes proofs chains in the delegated authorization chain
([#467](#467))
([5144293](5144293))
* move access-api delegation bytes out of d1 and into r2
([#578](#578))
([4510c9a](4510c9a))
* move validation flow to a Durable Object to make it ⏩ fast ⏩ fast ⏩
fast ⏩ ([#449](#449))
([02d7552](02d7552))
* provision provider type is now the DID of the w3s service
([#528](#528))
([6a72855](6a72855))
* space/info will not error for spaces that have had storage provider
added via provider/add
([#510](#510))
([ea4e872](ea4e872))
* upgrade capabilities to latest ucanto
([#463](#463))
([2d786ee](2d786ee))
* upgrade to new ucanto
([#498](#498))
([dcb41a9](dcb41a9))
* write invocations and receipts into ucan log
([#592](#592))
([754bf52](754bf52))


### Bug Fixes

* access/delegate checks hasStorageProvider(space) in a way that
provider/add allows access/delegate
([#483](#483))
([f4c640d](f4c640d))
* adjust migration 0005 to keep delegations table but create new used
delegations_v2
([#469](#469))
([a205ad1](a205ad1))
* adjust migration 0005 to not do a drop table and instead rename
delegations -&gt; delegations_old and create a new delegations
([#468](#468))
([6c8242d](6c8242d))
* allow injecting email
([#466](#466))
([e19847f](e19847f))
* DbDelegationsStorage#find throws UnexpectedDelegation w/ { row } if
failed bytesToDelegations
([#476](#476))
([a6dafcb](a6dafcb))
* DbProvisionsStorage putMany doesnt error on cid col conflict
([#517](#517))
([c1fea63](c1fea63))
* delegations model tries to handle if row.bytes is Array not Buffer
(e.g. cloudflare)
([#478](#478))
([030e7b7](030e7b7))


### Miscellaneous Chores

* **access-client:** release 11.0.0-rc.0
([#573](#573))
([be4386d](be4386d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@it-dag-house it-dag-house mentioned this pull request Mar 23, 2023
Closed
gobengo pushed a commit that referenced this pull request Apr 11, 2023
@Gozala
feat: includes proofs chains in the delegated authorization chain (#467)
743a72f 
This pr cleans up bunch of mess in the access/authorize code path and
starts including proof chains in the delegated authorization so agents
can actually utilize delegations.
gobengo pushed a commit that referenced this pull request Apr 11, 2023
@it-dag-house
chore(main): release capabilities 3.1.0 (#470)
0814eab 
🤖 I have created a release *beep* *boop*
---


##
[3.1.0](capabilities-v3.0.0...capabilities-v3.1.0)
(2023-03-04)


### Features

* access-api handles provider/add invocations
([#462](#462))
([46da0df](46da0df))
* includes proofs chains in the delegated authorization chain
([#467](#467))
([743a72f](743a72f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
gobengo pushed a commit that referenced this pull request Apr 11, 2023
@it-dag-house
chore(main): release access-api 5.0.0 (#588)
1230e7e 
🤖 I have created a release *beep* *boop*
---


##
[5.0.0](access-api-v4.11.0...access-api-v5.0.0)
(2023-03-23)


### ⚠ BREAKING CHANGES

* implement new account-based multi-device flow
([#433](#433))
* upgrade capabilities to latest ucanto
([#463](#463))

### Features

* access-api handles provider/add invocations
([#462](#462))
([46da0df](46da0df))
* access-api serves access/claim invocations
([#456](#456))
([2ec16e9](2ec16e9))
* access/authorize confirmation email click results in a delegation back
to the issuer did:key so that access/claim works
([#460](#460))
([fc62691](fc62691))
* allow multiple providers
([#595](#595))
([aba57b3](aba57b3))
* define `access/confirm` handler and use it in ucanto-test-utils
registerSpaces + validate-email handler
([#530](#530))
([a08b513](a08b513))
* handle access/delegate invocations without error
([#427](#427))
([db01d07](db01d07))
* if POST /validate-email?mode=authorize catches error w/ too big qr
code ([#516](#516))
([ab83b19](ab83b19))
* implement new account-based multi-device flow
([#433](#433))
([6152e55](6152e55))
* includes proofs chains in the delegated authorization chain
([#467](#467))
([743a72f](743a72f))
* move access-api delegation bytes out of d1 and into r2
([#578](#578))
([3029e4a](3029e4a))
* move validation flow to a Durable Object to make it ⏩ fast ⏩ fast ⏩
fast ⏩ ([#449](#449))
([3868d97](3868d97))
* provision provider type is now the DID of the w3s service
([#528](#528))
([4cd6cd9](4cd6cd9))
* space/info will not error for spaces that have had storage provider
added via provider/add
([#510](#510))
([362024f](362024f))
* upgrade capabilities to latest ucanto
([#463](#463))
([e375ae4](e375ae4))
* upgrade to new ucanto
([#498](#498))
([790750d](790750d))
* write invocations and receipts into ucan log
([#592](#592))
([d52a281](d52a281))


### Bug Fixes

* access/delegate checks hasStorageProvider(space) in a way that
provider/add allows access/delegate
([#483](#483))
([1d3d562](1d3d562))
* adjust migration 0005 to keep delegations table but create new used
delegations_v2
([#469](#469))
([d90825a](d90825a))
* adjust migration 0005 to not do a drop table and instead rename
delegations -&gt; delegations_old and create a new delegations
([#468](#468))
([89f2acd](89f2acd))
* allow injecting email
([#466](#466))
([b4b0173](b4b0173))
* DbDelegationsStorage#find throws UnexpectedDelegation w/ { row } if
failed bytesToDelegations
([#476](#476))
([660f773](660f773))
* DbProvisionsStorage putMany doesnt error on cid col conflict
([#517](#517))
([8c6dea8](8c6dea8))
* delegations model tries to handle if row.bytes is Array not Buffer
(e.g. cloudflare)
([#478](#478))
([02c0c28](02c0c28))


### Miscellaneous Chores

* **access-client:** release 11.0.0-rc.0
([#573](#573))
([29daa02](29daa02))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@dchoi27
feat: adjust language in register button (storacha#467)
70f408e 
Co-authored-by: Alan Shaw <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@github-actions
chore(main): release w3console 1.3.0 (storacha#468)
0e99f72 
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](storacha/w3ui@w3console-v1.2.0...w3console-v1.3.0)
(2023-03-24)


### Features

* add the NFT.Storage logo and make sure it looks nice
([storacha#465](storacha/w3ui#465))
([5e16e2f](storacha/w3ui@5e16e2f))
* adjust language in register button
([storacha#467](storacha/w3ui#467))
([70f408e](storacha/w3ui@70f408e))


### Bug Fixes

* get space registrar looking and acting right
([storacha#466](storacha/w3ui#466))
([616f781](storacha/w3ui@616f781))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
@dchoi27
feat: adjust language in register button (storacha#467)
871fa66 
Co-authored-by: Alan Shaw <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
@github-actions
chore(main): release w3console 1.3.0 (storacha#468)
9da90d7 
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](storacha/w3ui@w3console-v1.2.0...w3console-v1.3.0)
(2023-03-24)


### Features

* add the NFT.Storage logo and make sure it looks nice
([storacha#465](storacha/w3ui#465))
([975a4c5](storacha/w3ui@975a4c5))
* adjust language in register button
([storacha#467](storacha/w3ui#467))
([871fa66](storacha/w3ui@871fa66))


### Bug Fixes

* get space registrar looking and acting right
([storacha#466](storacha/w3ui#466))
([b36f7a5](storacha/w3ui@b36f7a5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gobengo gobengo gobengo approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
w3up phase 3
Development

Successfully merging this pull request may close these issues.
3 participants
@Gozala @gobengo @heyjay44