Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filecoin-api): parallel put to piece accept queue #1560

Merged
merged 2 commits into from
Oct 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 24 additions & 17 deletions packages/filecoin-api/src/aggregator/events.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Aggregator, Dealer } from '@web3-storage/filecoin-client'
import { Aggregate, Piece } from '@web3-storage/data-segment'
import { CBOR } from '@ucanto/core'
import map from 'p-map'

import {
getBufferedPieces,
Expand Down Expand Up @@ -225,24 +226,30 @@ export const handleAggregateInsertToPieceAcceptQueue = async (
}

// TODO: Batch per a maximum to queue
for (const piece of pieces) {
const inclusionProof = aggregateBuilder.resolveProof(piece.link)
if (inclusionProof.error) {
return inclusionProof
}
const addMessage = await context.pieceAcceptQueue.add({
piece: piece.link,
aggregate: aggregateBuilder.link,
group: bufferStoreRes.ok.buffer.group,
inclusion: {
subtree: inclusionProof.ok[0],
index: inclusionProof.ok[1],
},
})
const results = await map(
pieces,
/** @returns {Promise<import('@ucanto/interface').Result<import('@ucanto/interface').Unit, RangeError|import('../types.js').QueueAddError>>} */
async piece => {
const inclusionProof = aggregateBuilder.resolveProof(piece.link)
if (inclusionProof.error) return inclusionProof

const addMessage = await context.pieceAcceptQueue.add({
piece: piece.link,
aggregate: aggregateBuilder.link,
group: bufferStoreRes.ok.buffer.group,
inclusion: {
subtree: inclusionProof.ok[0],
index: inclusionProof.ok[1],
},
})
if (addMessage.error) return addMessage

if (addMessage.error) {
return addMessage
}
return { ok: {} }
},
{ concurrency: 10 }
)
for (const r of results) {
if (r.error) return r
}

return {
Expand Down
Loading