Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: De-deprecate AgentData's addSpace() #1557

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

Peeja
Copy link
Member

@Peeja Peeja commented Oct 4, 2024

This was deprecated in #433, but it's still what we use, and no clear migration path was given.

@alanshaw Do you remember what the plan was? Should we do this and reverse it, or is there a better way we should write down?

This was deprecated in #433, but
it's still what we use, and no clear migration path was given.
@Peeja Peeja requested a review from alanshaw October 4, 2024 15:39
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not fully remembered (sorry) but I think the idea was to signal early that we wanted to move away from the client storing state like the list of spaces, or the "current" space, beyond the delegations it has received/created. i.e. the list of spaces should be derivable from the delegations in the store.

My apologies - I should have documented and probably done in a separate PR...but hey, younger me was a maverick.

I'm happy to merge this but I still desire the goal above and so addSpace should not really exist, and addDelegation should be the only method here for adding spaces.

@Peeja Peeja merged commit 86af87d into main Oct 7, 2024
3 checks passed
@Peeja Peeja deleted the reprecate-addSpace branch October 7, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants