-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sharing spaces #1551
Merged
Merged
feat: sharing spaces #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
reviewed
Sep 17, 2024
8ed8d8e
to
f53a1e1
Compare
alanshaw
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me, just a few minor issues I think need to be addressed and then mergable :)
3725ec2
to
838a61d
Compare
alanshaw
approved these changes
Sep 20, 2024
fforbeck
pushed a commit
that referenced
this pull request
Sep 20, 2024
🤖 I have created a release *beep* *boop* --- ## [16.2.0](w3up-client-v16.1.1...w3up-client-v16.2.0) (2024-09-20) ### Features * sharing spaces ([#1551](#1551)) ([7deb9a4](7deb9a4)) ### Fixes * repo URLs ([#1550](#1550)) ([e02ddf3](e02ddf3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
shareSpace()
Method to Allow Sharing Spaces with Other AccountsSummary
This PR introduces a new
shareSpace()
method that allows users to delegate access to an existing space with another Storacha account via email. This feature enhances collaboration by enabling multiple accounts to share access to a space, making data sharing more flexible.By default, the following capabilities/permissions are set:
Changes
New Feature: Space Sharing
shareSpace()
Method:shareSpace()
method allows users to share an existing space with another Storacha account by delegating access to the specified email address.space
: The space to be shared, identified by its DID.delegateEmail
: The email address of the account to share the space with.How to Test
Ensure all existing tests pass.
Verify that the new test cases for the
shareSpace()
method function correctly.Related Issues
Additional Notes
This implementation opens the door for future enhancements, such as specifying different permission levels when sharing spaces.