Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload client should perform filecoin offer #1333

Merged
merged 4 commits into from
Mar 21, 2024
Merged

fix: upload client should perform filecoin offer #1333

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f67eee
fix: upload client should perform filecoin offer
vasco-santos Mar 20, 2024
aaefd5f
chore: improve comment
vasco-santos Mar 21, 2024
5329ce2
chore: address review comments
vasco-santos Mar 21, 2024
f41b032
chore: fix format
vasco-santos Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: improve comment
  • Loading branch information
@vasco-santos
vasco-santos committed Mar 21, 2024
commit aaefd5f5ade3acab241633467db47a6cd2af4d65
2 changes: 1 addition & 1 deletion packages/upload-client/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ async function uploadBlockStream(conf, blocks, options = {}) {
{
issuer: conf.issuer,
audience: conf.audience,
// Resource of storefront is the issuer did
// Resource of invocation is the issuer did for being self issued
with: conf.issuer.did(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand why this is the issuer?

https://github.com/web3-storage/w3up/blob/f5bac9d27610d976d1144ea12a5c6f9448e7974a/packages/capabilities/src/filecoin/storefront.js#L22-L25

lolz looks like I wrote that comment...still why?

Copy link
Contributor Author

@vasco-santos vasco-santos Mar 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comment is actually also wrong, the did must be the same as the issuer in order to have a self issued invocation.. Otherwise you would need to either have been delegated such capability or inline proofs given resource is not did of issuer.

proofs: conf.proofs,
},
Expand Down
Loading