Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: w3up-client README replace links to old tsdoc with links to correct/new tsdoc from monorepo #1218

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Dec 5, 2023

@gobengo gobengo changed the title w3up-client README replace links to old tsdoc with links to correct/new tsdoc from monorepo fix: w3up-client README replace links to old tsdoc with links to correct/new tsdoc from monorepo Dec 5, 2023
@gobengo gobengo changed the title fix: w3up-client README replace links to old tsdoc with links to correct/new tsdoc from monorepo docs: w3up-client README replace links to old tsdoc with links to correct/new tsdoc from monorepo Dec 5, 2023
@gobengo gobengo marked this pull request as ready for review December 5, 2023 17:43
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a small tweak needed...

@@ -156,7 +156,7 @@ await client.setCurrentSpace(space.did())

#### Delegating from Space to Agent

In order to store data with w3up, your Agent will need a delegation from a Space. This automatically happens if you called `login(email)` then `registerSpace()`. However, if you are initializing the client with a previously created Space, you can `login(email)` then claim a delegation granted to the account associated with your email:
In order to store data with w3up, your Agent will need a delegation from a Space. This automatically happens if you called `Account#provision` on a space. However, if you are initializing the client with a previously created Space, you can `login(email)` then claim a delegation granted to the account associated with your email:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think login does this automatically - i.e. no need to call await capability.access.claim()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gobengo gobengo merged commit 153da70 into main Dec 5, 2023
3 checks passed
@gobengo gobengo deleted the w3up-docs-trip-1701796824 branch December 5, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants