feat: allow alternative audience for server #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
volmedo
added a commit
to storacha/go-ucanto
that referenced
this pull request
Feb 26, 2025
Part of #35 This PR ports the changes added to the JS ucanto library here: storacha/ucanto#371 It adds a new `WithAlternativeAudiences` option that can be used when creating the server to have it accept invocations targeted to audiences different from the server's main identity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new server option
audience, which allows the server to accept invocations for audiences other than the service itself.This option was already available (and continues to be available) on a per handler basis (via
provideAdvanced), it takes precedence over the new global server audience.Concretely, the DID for web3.storage is changing, but we want to be able to accept invocations targeting the old DID without having to configure every single handler.