fix: add @returns to @ucanto/validator Schema.dictionary() to avoid problematic inference when using derives #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matic inference when using derives
gobengo
commented
Feb 2, 2023
| derives: (claim, proof) => { | ||
| // the motivation for this test was that tsc would previously complain at these assignments | ||
| // and the only workaround was a type assertion https://github.com/web3-storage/w3protocol/pull/420/commits/4f1f2931cecff1d1d1d29e889c4fdfb63ff3b327#diff-e434cc6c1a699df311a0b2faed199a2ff6b6b291d30f95e20b2ea5abfa7da3d9R125 | ||
| /** @type {Schema.Dictionary|undefined} */ |
There was a problem hiding this comment.
tsc will complain here without the change adding @returns to Schema.dictionary().
There was a problem hiding this comment.
This is cool, but since we're testing inference as opposed to something at runtime I would suggest putting it in this file instead https://github.com/web3-storage/ucanto/blob/main/packages/validator/test/inference.spec.js
There was a problem hiding this comment.
thanks, I did feel weird that it was a tsc-only test alongside a bunch of runtime ones, but figured you'd either tell me to just omit the test or lmk a good place to put it :) 🙏
Gozala
approved these changes
Feb 2, 2023
gobengo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: