Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make npm package, npm start uses eleventy to render specs #91

Closed
wants to merge 16 commits into from

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Jan 17, 2024

motivation:

  • quick experiment
Screenshot 2024-01-17 at 1 49 54 PM

@gobengo gobengo requested a review from olizilla January 17, 2024 21:50
@gobengo gobengo self-assigned this Jan 17, 2024
…this should justify this becoming a separate specs-website package
@gobengo
Copy link
Contributor Author

gobengo commented Jan 17, 2024

so now herokuish and/or dokku will test/build/deploy it to something like https://w3-specs.dokku.bengo.is/

Copy link

github-actions bot commented Jan 17, 2024

@gobengo
Copy link
Contributor Author

gobengo commented Jan 17, 2024

no idea why some of the characters get mangled in the html generated by add-to-web3! 😅 I'm assuming the way it builds in github actions does string encoding differently? example of weird chars

@gobengo gobengo marked this pull request as ready for review January 17, 2024 23:58
index.webc Outdated
Comment on lines 1 to 2
<!doctype html>
<h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suspect this needs more

  <meta charset="utf-8">

Or maybe the gateway isn't able to guess the mime type. Maybe needs .html extension.

Add-to-web3 is just calling w3 up.

@gobengo gobengo marked this pull request as draft January 18, 2024 21:42
@gobengo gobengo removed their assignment Jan 18, 2024
@gobengo gobengo closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants