Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps): update to new blob-fetcher #150

Merged
merged 2 commits into from
Feb 5, 2025
Merged

feat(deps): update to new blob-fetcher #150

merged 2 commits into from
Feb 5, 2025

Conversation

hannahhoward
Copy link
Member

Goals

Use the new refactor freeway

Implementation

  • update dependencies for blob-fetcher & indexing-service-client
  • update withLocator to use new initializations
  • change on the factories for location claims in the tests -- this is weird cause normally I'd say tests breaking is a bad sign, but this certianly appears to be a genuine bug in the factor that was covered up by a potential bug in the old code (always using digest as the location claim's key even if content in the actual claim was different)

Peeja
Peeja approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@Peeja Peeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hannahhoward hannahhoward merged commit 87e3298 into main Feb 5, 2025
1 check passed
@hannahhoward hannahhoward deleted the feat/use-refactored-blob-fetcher branch February 5, 2025 10:13
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Merged
hannahhoward pushed a commit that referenced this pull request Feb 5, 2025
@github-actions
chore(main): release 2.26.0 (#151)
b751682 
🤖 I have created a release *beep* *boop*
---


##
[2.26.0](v2.25.0...v2.26.0)
(2025-02-05)


### Features

* **deps:** update to new blob-fetcher
([#150](#150))
([87e3298](87e3298))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peeja Peeja Peeja approved these changes

@fforbeck fforbeck fforbeck approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannahhoward @Peeja @fforbeck