-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: arrayish given #799
feat: arrayish given #799
Conversation
would this mean
|
@jerzyn |
i should do these examples professionally ;) |
9b165a0
to
5113caa
Compare
## Given | ||
|
||
The `given` keyword is, besides `then`, the only required property on each rule definition. | ||
It can be any valid JSONPath expression or an array of JSONPath expressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@P0lip Nit: From a reader's perspective, it's not very clear if, for the rule to pass, all the expressions have to satisfy the expectation or at least one of them.
Checklist
Does this PR introduce a breaking change?
Currently we only allow a single JSON path expression to be provided at a time for each rule.
That limitation may lead to a situation where a complex json path expression needs to be provided in order to match all intended properties. In most cases, those expressions could be split into 2-3 that would be much simpler.