fix(request): proxy-agent breaks Studio #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/request.ts
Outdated
| const options = | ||
| typeof process === 'object' && process.env.PROXY ? { ...opts, agent: new ProxyAgent(process.env.PROXY) } : opts; | ||
| if (typeof process === 'object' && process.env.PROXY) { | ||
| try { |
There was a problem hiding this comment.
Is this going to import every time a request is made? Is that gonna be ok for performance/memory usage?
There was a problem hiding this comment.
Good point!
Luckily, Node.js caches modules (can be checked under require.cache), therefore they are loaded and executed only once unless one clears the cache.
That said, we should be okay.
Note, even though import is used here, it's replaced with a require call when we compile the code from TS to JS.
I don't take bundlers into account, since we don't aim to run this code in a browser, but they are no different.
P0lip
commented
Sep 24, 2019
| ====stdout==== | ||
|
|
||
| {document} | ||
| 2:9 error invalid-ref FetchError: request to http://localhost:3002/foo.json failed, reason: connect ECONNREFUSED 127.0.0.1:3001 |
There was a problem hiding this comment.
This is a tad dumb. We could spin up a server.
Should be fine for now.
marbemac
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Does this PR introduce a breaking change?
Additional context
This is almost impossible to cover with tests, as Studio has quite a specific setup. We just gotta be careful and avoid running Node specific code as much as possible.