Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ruleset): allow require calls in Node.JS #1011

Merged
merged 9 commits into from
Mar 15, 2020
Merged

feat(ruleset): allow require calls in Node.JS #1011

merged 9 commits into from
Mar 15, 2020

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Mar 12, 2020 •
edited
Loading

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added enhancement New feature or request WIP labels Mar 12, 2020
@P0lip P0lip self-assigned this Mar 12, 2020
@P0lip P0lip force-pushed the feat/evaluate-require-calls branch from 058f3b4 to c4f7d23 Compare March 12, 2020 13:26
@P0lip P0lip removed the WIP label Mar 12, 2020
@P0lip P0lip requested review from marbemac and nulltoken March 12, 2020 14:42
@P0lip P0lip marked this pull request as ready for review March 12, 2020 14:42
@P0lip P0lip marked this pull request as ready for review March 12, 2020 14:42
@P0lip P0lip requested a review from philsturgeon March 12, 2020 14:42
philsturgeon
philsturgeon reviewed Mar 12, 2020
View reviewed changes
Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @nulltoken could you review this and approve/request changes?

Phil Sturgeon and others added 3 commits March 13, 2020 10:07
@P0lip P0lip requested a review from nulltoken March 14, 2020 19:20
nulltoken
nulltoken previously approved these changes Mar 14, 2020
View reviewed changes
@P0lip P0lip force-pushed the feat/evaluate-require-calls branch from 6dba96a to 69c04d8 Compare March 15, 2020 10:53
@P0lip P0lip force-pushed the feat/evaluate-require-calls branch from 69c04d8 to 750ccae Compare March 15, 2020 11:13
@P0lip P0lip merged commit d5f11ba into develop Mar 15, 2020
@P0lip P0lip deleted the feat/evaluate-require-calls branch March 15, 2020 11:26
@philsturgeon
Copy link
Contributor

Yay thank you @P0lip! Shall we get a 5.2 out so that ruleset exceptions can be used in Studio, the YAML trouble in Studio will be resolved, and @mkistler can have this feature to play with?

@P0lip
Copy link
Contributor Author

P0lip commented Mar 15, 2020

@philsturgeon
Yes, that's the plan! I'm thinking of Monday or Tuesday, as indeed we have ruleset exceptions in, as well as a couple of other fixes.

@RobPhippen
Copy link

@philsturgeon @P0lip This is very good news! This has been a deal-breaker for me adopting spectral (FYI I am working with @mkistler )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVincentX XVincentX XVincentX left review comments

@philsturgeon philsturgeon philsturgeon left review comments

@nulltoken nulltoken nulltoken left review comments

@marbemac marbemac Awaiting requested review from marbemac

Assignees

@P0lip P0lip

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@P0lip @philsturgeon @RobPhippen @nulltoken @XVincentX