-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operation-2xx-response
rule should not be recommended
#1273
Comments
@krystof-k hey there! Could you explain the use case a little more? What is happening with your API where only 3xx is coming out of it? I seem to remember the YouTube API used to do this, where a successful POST would then say "this worked out and you should follow to the If you want room to be creative, you can turn that rule off, but maybe there is a legit use case I'm forgetting and you could help remind me! |
We use it for forwarding to pre-signed URL on AWS S3. Client requests Not sure whether this is a best practise, I was doing some research and the only thing I found was Microsoft OneDrive, but maybe there is a better way to do it :) |
Ahh nice use case. Ok, let's change this rule from |
Cool! :) BTW thanks for mentioning |
* BREAKING: removed operation-default-response The spec says: The default MAY be used as a default response object for all HTTP codes that are not covered individually by the specification. There's no need to suggest anyone default is any more important than optional. * chore: remove nvmrc lets let people run this with whatever version and the CI will confirm it works with versions we care about. * fixes #1273: allow 2xx or 3xx responses * BREAKING: Made openapi-tags not recommended If you want to use it, switch from to fixes #1132 * put nvmrc back Co-authored-by: Phil Sturgeon <[email protected]>
I suggest to move
operation-2xx-response
rule out from recommended, as it is reasonable to have endpoints that have no success response but only 3xx redirects. Or maybe change the rule to allow 2xx or 3xx responses.What do you think?
The text was updated successfully, but these errors were encountered: