Izhang validation webhook #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 15, 2020 17:52
Signed-off-by: ianzhang366 <[email protected]>
Signed-off-by: ianzhang366 <[email protected]> working webhook set up
Signed-off-by: ianzhang366 <[email protected]>
Signed-off-by: ianzhang366 <[email protected]> working refactor Signed-off-by: ianzhang366 <[email protected]>
Signed-off-by: ianzhang366 <[email protected]> more test case Signed-off-by: ianzhang366 <[email protected]> add test case Signed-off-by: ianzhang366 <[email protected]>
rokej
approved these changes
May 29, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ianzhang366, rokej, xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ianzhang366 <[email protected]>
|
New changes are detected. LGTM label has been removed. |
added 5 commits
May 29, 2020 18:39
Signed-off-by: ianzhang366 <[email protected]>
Signed-off-by: ianzhang366 <[email protected]>
Signed-off-by: ianzhang366 <[email protected]>
Signed-off-by: ianzhang366 <[email protected]>
Signed-off-by: ianzhang366 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
magic-mirror-bot bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
Signed-off-by: Xiangjing Li <[email protected]> (cherry picked from commit 7b86a94befdc2e71544b5d8479be25e54362b5c5)
magic-mirror-bot bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
Signed-off-by: Xiangjing Li <[email protected]> (cherry picked from commit 7b86a94befdc2e71544b5d8479be25e54362b5c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue(when multiple types of the channel at 1 namespace crash the channel operator):
https://github.com/open-cluster-management/backlog/issues/2265
https://github.com/open-cluster-management/backlog/issues/2310
Basically, we add a validation webhook.
The validation logic is defined at issue:
https://github.com/open-cluster-management/backlog/issues/2157
To support the webhook, we need to create
servicefor k8s-server to call on the webhook we createdValidatingWebhookConfiguration, tells k8s to call the webhook service whenchannelresource is created or updated.In addition, we need to create a self-signed cert and inject the CA to
ValidatingWebhookConfiguration.