Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [twd] fix some design flaws #1161

Merged
merged 5 commits into from
Jan 16, 2025
Merged

🐛 [twd] fix some design flaws #1161

merged 5 commits into from
Jan 16, 2025

Conversation

stnolting
Copy link
Owner

This PR fixes several design flaws:

  • 🐛 drive SDA line only if READ operation
  • 🐛 wait for STOP condition if a READ transfer has received a NACK
  • only write received I2C data to the internal RX FIFO if an actual WRITE operation in in progress
  • check for STOP condition also in ACK/NACK timeslot (if possible)

triggered in #1157 and replacing #1158

@stnolting stnolting added bug Something isn't working as expected HW Hardware-related labels Jan 16, 2025
@stnolting stnolting self-assigned this Jan 16, 2025
@stnolting stnolting mentioned this pull request Jan 16, 2025
Closed
@stnolting stnolting linked an issue Jan 16, 2025 that may be closed by this pull request
TWD going into idle depends on TX Fifo content #1157
Closed
@stnolting stnolting marked this pull request as ready for review January 16, 2025 17:41
@stnolting stnolting merged commit df9fc4c into main Jan 16, 2025
10 checks passed
@stnolting stnolting deleted the twd_fixes branch January 16, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stnolting stnolting

Labels
bug Something isn't working as expected HW Hardware-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TWD going into idle depends on TX Fifo content
1 participant
@stnolting