Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(simple-storage/device): add device name #168

Merged
merged 1 commit into from
Apr 8, 2022
Merged

fix(simple-storage/device): add device name #168

merged 1 commit into from
Apr 8, 2022

Conversation

mahuihuang
Copy link
Contributor

Add a name field to distinguish between devices.

stmcginnis
stmcginnis approved these changes Apr 8, 2022
View reviewed changes
Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@stmcginnis
Copy link
Owner

Looks like I need to update the linter rules. Failure is not related to this change.

@stmcginnis stmcginnis merged commit 3dc66db into stmcginnis:main Apr 8, 2022
@mahuihuang mahuihuang deleted the simple_storage_device branch April 8, 2022 15:22
@mahuihuang
Copy link
Contributor Author

Excuse me, when will the next stable version be released? I have a project that uses this dependency.

@stmcginnis
Copy link
Owner

You can always reference by sha in your go.mod, but I can tag an actual release if that makes it easier.

@stmcginnis
Copy link
Owner

Published: https://github.com/stmcginnis/gofish/releases/tag/v0.13.0

@mahuihuang
Copy link
Contributor Author

Thank you for your reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcginnis stmcginnis stmcginnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahuihuang @stmcginnis