Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration function to enable or disable automatic retransmit #42

Merged
merged 7 commits into from
Jun 25, 2021

Conversation

samcrow
Copy link
Contributor

@samcrow samcrow commented Jun 25, 2021

In some cases, we don't want the CAN peripheral to repeatedly try to transmit again each frame that cannot be transmitted.
With this pull request, I am proposing a small change that adds a function to CanConfig to enable or disable automatic retransmission using the NART bit.

@jonas-schievink
Copy link
Contributor

Thanks, this looks good! Can you extend the docs to mention that automatic retransmit is enabled by default?

@samcrow
Copy link
Contributor Author

samcrow commented Jun 25, 2021

I added a note to the set_automatic_retransmit documentation. is that good?

@jonas-schievink
Copy link
Contributor

Yup, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 25, 2021

Build succeeded:

@bors bors bot merged commit d1df9b0 into stm32-rs:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants