Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP formatting settings for VS Code #26

Draft
wants to merge 1 commit into
base: 9.x
Choose a base branch
from

Conversation

brianjohnhanna
Copy link
Collaborator

Changes the default formatter used in the VS Code workspace settings to one that implements PHPCBF and PHPCS

TODO

  • Need to include instructions for setting up the plugin/dev environment. We either need to ensure PHPCS and PHPCBF are installed as composer devDependencies (easiest) or provide instructions for updating the settings for the plugin to point to global composer dependencies, since it didn't recognize them in my PATH. (more info here)
  • Add Husky rule to ensure no PHPCS rules are disallowed on push. This will increase adoption and uniform code style but we'll have to make sure everyone on PHPStorm is also setup properly from the start.
  • Add any PHPCS rules relevant to Blade, and re-evaluate if we want to keep the blade formatter (onecentlin.laravel-blade) extension and should include in extensions.json or if the PHPCBF can handle it with appropriate configuration.
    • Note we can leave this plugin included for syntax highlighting and disable formatting with "blade.format.enable": false

See #25 for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant