Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added upsert method to move a specific item to the start. #209

Merged

Conversation

PrimozPernat
Copy link

Created a solution as mentioned in #201

@PrimozPernat
Copy link
Author

@stfalcon @hbmartin @fre5h @philippeauriach Hello everyone. Can I bother one who has the write permission to go over the small PR and merge it? That would be appreciated.

@bevzaanton
Copy link
Contributor

Hi @PrimozPernat ! Sorry that I did not reply for a while. PR looks very good. But why you made some fields and methods public? Maybe will be better if you make them protected. In this way users will have access to those fields and method by extending MessagesListAdapter.
And if you have time, can you add new upsert method to the documentation?

- List<Wrapper> items
- method `generateDateHeaders`
@PrimozPernat
Copy link
Author

PrimozPernat commented Oct 11, 2018

@bevzaanton Thank you for the replay. I changed the access modifier for the items list and the method generateDateHeaders to protected. But the inner class Wrapper<DATA> has to be public because if someone wants to extend the MessagesListAdapter he can't access item in the list.

P.S.: I will update the documentation at the weekend.

@bevzaanton
Copy link
Contributor

bevzaanton commented Oct 12, 2018

@PrimozPernat thanks for PR! I will upload ChatKit version 0.3.3 with your changes.

@bevzaanton bevzaanton merged commit c143b4a into stfalcon-studio:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants