Enrich MDC with request method and request URI #771
Merged
+176
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs emitted during request handling can be ambiguous if a resource class contains many methods. Access control failure logs are harder to interpret without the additional context of which endpoint was attempted to be accessed. This change enriches the logger's MDC with both the request method, and the request URI. If an endpoint accepts path parameters, the `requestUri` MDC variable will only contain the respective placeholder, *not* the parameter values themselves. This keeps values constant, making it easier to filter through logs. Signed-off-by: nscuro <[email protected]>
nscuro
force-pushed
the
mdc-request-metadata-enrichment
branch
from
3f73538 to
a62ea8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs emitted during request handling can be ambiguous if a resource class contains many methods.
Access control failure logs are harder to interpret without the additional context of which endpoint was attempted to be accessed.
This change enriches the logger's MDC with both the request method, and the request URI.
If an endpoint accepts path parameters, the
requestUriMDC variable will only contain the respective placeholder, not the parameter values themselves. This keeps values constant, making it easier to filter through logs.