Allow for configuration of both primary and secondary db connection pool #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of implicitly applying the same property values for both pool types. Signed-off-by: nscuro <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
alpine-server/src/main/java/alpine/server/persistence/PersistenceManagerFactory.java
Show resolved
Hide resolved
5 tasks
nscuro
added a commit
to nscuro/Alpine
that referenced
this pull request
May 1, 2024
As reported via DependencyTrack/dependency-track#1987 This appears to be a regression introduced via stevespringett#439. Signed-off-by: nscuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of implicitly applying the same property values for both pool types.
See DependencyTrack/dependency-track#1935 for context.
This PR introduces new config keys for both the primary (transactional,
tx) and secondary (*non-transactional,nontx) connection pools, all which default tonulland fall back to the existing pool config keys to remain backward compatible.