Save and load secret key using encoded bytes format instead of Object Serialization #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Serialization Using OS makes it impractical to provide a key that was generated before Alpine / the application using Alpine was first launched. Secret keys can be loaded both in the old and the new format. This is done for backwards compatibility. Existing deployments of Alpine-based apps will not have to do anything and continue to function as before. New keys will only be generated in the new encoded format. There is no automatic conversion of existing keys happening, because some users of Alpine may already have the key file set to read-only. Additionally, the location of the secret key is now configurable. This is important to have when using k8s secrets, as nested mounts (e.g. `-v "./data:/data" -v "./secret.key:/data/.alpine/keys/secret.key"`) are an anti-pattern. Closes stevespringett#436
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
5 tasks
nscuro
added a commit
to nscuro/Alpine
that referenced
this pull request
Jul 17, 2023
Similarly to what was done for the secret key in stevespringett#437, this allows pre-generated keys mounted into the application's container to be used. This is necessary to support deployments where multiple app instances must share the same keys. Signed-off-by: nscuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using OS makes it impractical to provide a key that was generated before Alpine / the application using Alpine was first launched.
Secret keys can be loaded both in the old and the new format. This is done for backwards compatibility. Existing deployments of Alpine-based apps will not have to do anything and continue to function as before.
New keys will only be generated in the new encoded format. There is no automatic conversion of existing keys happening, because some users of Alpine may already have the key file set to read-only.
Additionally, the location of the secret key is now configurable. This is important to have when using k8s secrets, as nested mounts (e.g.
-v "./data:/data" -v "./secret.key:/data/.alpine/keys/secret.key") are an anti-pattern.Closes #436