feat(request): add request provider for SSR without adding express as… #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@valorkin thanks for the PR. Would you mind explaining the process you followed i.e. what does new package |
pavankjadda
reviewed
Jan 13, 2022
| @@ -14,7 +15,8 @@ export class CookieService { | |||
| constructor( | |||
| @Inject(DOCUMENT) private document: Document, | |||
| // Get the `PLATFORM_ID` so we can check if we're in a browser. | |||
| @Inject(PLATFORM_ID) private platformId | |||
| @Inject(PLATFORM_ID) private platformId: any, | |||
| @Optional() @Inject(REQUEST_PROVIDER_TOKEN) private request: RequestProvider | |||
There was a problem hiding this comment.
@valorkin I see you created Injection Token and supplied it here. Does it work for CSR along with SSR application? Would you mind creating a sample repo so that we can test this.
@stevermeister take a look at this
There was a problem hiding this comment.
yes, now playing with it here - https://github.com/stevermeister/ssr-coookie
| return request; | ||
| }; | ||
|
|
||
| export const expressRequestProvider: StaticProvider = { |
There was a problem hiding this comment.
To be honest I have very little knowledge on this. I will read more about this
|
@pavankjadda you can discuss it with @stevermeister |
Closed
|
Closes in favor of #237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… a dep to a client lib