Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim.ui.select error creating window when some string sent by the language server contains newline #88

Closed
goolord opened this issue Feb 24, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@goolord
Copy link

goolord commented Feb 24, 2023

Describe the bug
dressing.nvim can fail to create a window when some string the language server sends contains newlines. this bug is also present in nvim-telescope/telescope-ui-select.nvim#19

System information

  • OS: mac
  • Neovim version: v0.9.0-dev-2126+g84328bae0-dirty
  • Telescope backend
  • Dressing config:
require("dressing").setup()

To Reproduce
Steps to reproduce the behavior:

  1. enter a project that does not build with HLS
  2. wait for haskell language server to send error message + retry option

If possible, provide a minimal file that will trigger the issue (see
tests/manual
for examples of short ways to call vim.ui.*):

minimal code here

Screenshots
vanilla vim.ui.select:
image

dressing.nvim vim.ui.select:
image

@goolord goolord added the bug Something isn't working label Feb 24, 2023
@stevearc
Copy link
Owner

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants