Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] telescope theme deprecation notice shown continuously #26

Closed
akinsho opened this issue Mar 17, 2022 · 2 comments
Closed

[Bug] telescope theme deprecation notice shown continuously #26

akinsho opened this issue Mar 17, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@akinsho
Copy link
Contributor

akinsho commented Mar 17, 2022

Describe the bug
The recent telescope theme deprecation warning is shown continuously because the telescope theme object itself actually has a key called theme, so this wrongly reports that a user hasn't migrated despite having done so.

System information

  • OS: [windows/linux/mac] macOS
  • Neovim version: nightly
  • Is this related to a specific vim.ui.select backend? If so, which one? Telescope
  • Dressing config:
use {
      'stevearc/dressing.nvim',
      after = 'telescope.nvim',
      config = function()
        require('dressing').setup {
          input = {
            insert_only = false,
            winblend = 2,
          },
          select = {
            telescope = require('telescope.themes').get_cursor { -- <--- This function returns an object with a theme key
              layout_config = {
                height = function(self, _, max_lines)
                  local results = #self.finder.results
                  return (results <= max_lines and results or max_lines - 10) + 4 -- 4 is the size of the window
                end,
              },
            },
          },
        }
      end

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

  telescope = {                                                                                                                                                                      
    borderchars = {                                                                                                                                                                  
      preview = { "", "", "", "", "", "", "", "" },                                                                                                                          
      prompt = { "", "", " ", "", "", "", "", "" },                                                                                                                           
      results = { "", "", "", "", "", "", "", "" }                                                                                                                           
    },                                                                                                                                                                               
    layout_config = {                                                                                                                                                                
      height = <function 2>,                                                                                                                                                         
      width = 80                                                                                                                                                                     
    },                                                                                                                                                                               
    layout_strategy = "cursor",                                                                                                                                                      
    results_title = false,                                                                                                                                                           
    sorting_strategy = "ascending",                                                                                                                                                  
    theme = "cursor"                                                                                                                                                                 
  } 
@akinsho akinsho added the bug Something isn't working label Mar 17, 2022
@stevearc
Copy link
Owner

Should be fixed now. Thanks for the report!

@akinsho
Copy link
Contributor Author

akinsho commented Mar 17, 2022

Awesome, thanks can confirm that's fixed now 👍🏿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants