-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(configuration): warn users about the usage of asynchronous global scripts #1350
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - had one non-blocking ask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm misunderstanding something I think this change should only be made in docs/
since it has to do with unreleased code - we aren't planning to release a 3.x.x
version or republish our 4.x.x
versions with this change, right?
Co-authored-by: Alice Pote <[email protected]>
@alicewriteswrongs good call, yeah I think it should only be for the latest docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
although I guess we want to wait until stenciljs/core#5158 merges! |
Merged. |
As async global scripts will be supported in stenciljs/core#5158 we should warn about the implications of using this feature as it can add delays in rendering the application.