Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(configuration): warn users about the usage of asynchronous global scripts #1350

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

christian-bromann
Copy link
Member

As async global scripts will be supported in stenciljs/core#5158 we should warn about the implications of using this feature as it can add delays in rendering the application.

@christian-bromann christian-bromann requested a review from a team as a code owner February 8, 2024 00:37
@christian-bromann christian-bromann requested review from rwaskiewicz and tanner-reits and removed request for a team February 8, 2024 00:37
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 5:49pm

Copy link
Contributor

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - had one non-blocking ask

Copy link
Contributor

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm misunderstanding something I think this change should only be made in docs/ since it has to do with unreleased code - we aren't planning to release a 3.x.x version or republish our 4.x.x versions with this change, right?

@christian-bromann
Copy link
Member Author

@alicewriteswrongs good call, yeah I think it should only be for the latest docs.

Copy link
Contributor

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alicewriteswrongs
Copy link
Contributor

although I guess we want to wait until stenciljs/core#5158 merges!

@christian-bromann
Copy link
Member Author

although I guess we want to wait until ionic-team/stencil#5158 merges!

Merged.

@christian-bromann christian-bromann merged commit c8a1a83 into main Feb 8, 2024
5 checks passed
@christian-bromann christian-bromann deleted the cb/global-script-perf-limitation branch February 8, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants