Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm test
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently, the package declares a need for Stencil version >=2.0.0. When we install the v3 beta, we get error warnings that we violate this constraint
GitHub Issue Number: N/A
What is the new behavior?
this commit bumps the values of
package.json#peerDependencies
to accept v3.0.0 of stencil.Does this introduce a breaking change?
Testing
This commit was validated in the Ionic Framework with the changes that @alicewriteswrongs made in stenciljs/output-targets#318. To verify this yourself:
npm ci && npm run build && npm pack
<- Also helps validate the changes to the manifest and lockfile are semi-well formed (would show an error message if there was a parse error)2.1.
npm run bootstrap && npm run build
2.2.
pushd packages/angular-output-target && npm pack && popd
2.3.
pushd packages/react-output-target && npm pack && popd
2.4.
pushd packages/vue-output-target && npm pack && popd
3.1.
cd core && npm ci
3.2.
npm i @stencil/core@v3-latest [stencil-sass-tarball] [angular-wrapper-tarball] [react-wrapper-tarball] [vue-wrapper-tarball]
3.3. Observe no errors in the install
Other information