Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): run copy task after other output targets #5902

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

christian-bromann
Copy link
Member

What is the current behavior?

The copy task is run at the same time as other output targets which doesn't allow users to include any of the build artifacts into the copy task.

GitHub Issue Number: fixes #5592

What is the new behavior?

Run the copy task after all build artifacts are generated. Since outputCopy, outputWww, outputDocs, outputTypes and outputCustom are not dependent on each other I wrapped them into a Promise.all so we don't increase the build time due to more sequential calls.

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

Not sure how to properly test this, hence if current build passes I would feel confident moving forward.

Other information

STENCIL-1327

@christian-bromann christian-bromann requested a review from a team as a code owner July 22, 2024 21:34
Copy link
Contributor

@stencil/[email protected] ts
tsc --noEmit --project scripts/tsconfig.json && tsx scripts/tech-debt-burndown-report.ts

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1068 errors on this branch.

That's the same number of errors on main, so at least we're not creating new ones!

reports and statistics

Our most error-prone files
Path Error Count
src/dev-server/index.ts 37
src/dev-server/server-process.ts 32
src/compiler/prerender/prerender-main.ts 22
src/runtime/vdom/vdom-render.ts 22
src/runtime/client-hydrate.ts 20
src/runtime/vdom/test/patch.spec.ts 19
src/runtime/vdom/test/util.spec.ts 19
src/screenshot/connector-base.ts 19
src/testing/puppeteer/puppeteer-element.ts 19
src/dev-server/request-handler.ts 15
src/compiler/prerender/prerender-optimize.ts 14
src/compiler/sys/stencil-sys.ts 14
src/runtime/connected-callback.ts 14
src/sys/node/node-sys.ts 14
src/compiler/prerender/prerender-queue.ts 13
src/compiler/sys/in-memory-fs.ts 13
src/runtime/set-value.ts 13
src/compiler/output-targets/output-www.ts 12
src/compiler/transformers/test/parse-vdom.spec.ts 12
src/compiler/transformers/transform-utils.ts 12
Our most common errors
Typescript Error Code Count
TS2322 338
TS2345 326
TS18048 188
TS18047 99
TS2722 27
TS2531 19
TS2532 18
TS2790 11
TS2454 10
TS2352 9
TS2769 8
TS2416 7
TS2538 4
TS18046 2
TS2684 1
TS2430 1

Unused exports report

There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports
File Line Identifier
src/runtime/bootstrap-lazy.ts 21 setNonce
src/screenshot/screenshot-fs.ts 18 readScreenshotData
src/testing/testing-utils.ts 198 withSilentWarn
src/utils/index.ts 145 CUSTOM
src/utils/index.ts 245 NODE_TYPES
src/utils/index.ts 269 normalize
src/utils/index.ts 7 escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts 25 BUILD
src/compiler/app-core/app-data.ts 116 Env
src/compiler/app-core/app-data.ts 118 NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts 123 updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts 82 satisfies
src/compiler/types/validate-primary-package-output-target.ts 82 Record
src/testing/puppeteer/puppeteer-declarations.ts 496 WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts 7 writeFetchSuccessSync

Copy link
Contributor

PR built and packed!

Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/10048733965/artifacts/1727871765

If your browser saves files to ~/Downloads you can install it like so:

unzip -d ~/Downloads ~/Downloads/stencil-core-4.19.2-dev.1721684140.19d8445.tgz.zip && npm install ~/Downloads/stencil-core-4.19.2-dev.1721684140.19d8445.tgz

@christian-bromann christian-bromann added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit c3d4e8b Jul 29, 2024
92 checks passed
@christian-bromann christian-bromann deleted the cb/copy-ot-fix branch July 29, 2024 18:11
christian-bromann added a commit that referenced this pull request Jul 30, 2024
* fix(compiler): run copy task after other output targets

* run secondary tasks in parallel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Copy task runs in parallel to build tasks creating a race condition
2 participants