chore(wdio): convert event-custom-type to wdio #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Path | Error Count |
|---|---|
| src/dev-server/index.ts | 37 |
| src/dev-server/server-process.ts | 32 |
| src/compiler/prerender/prerender-main.ts | 22 |
| src/testing/puppeteer/puppeteer-element.ts | 22 |
| src/runtime/client-hydrate.ts | 20 |
| src/screenshot/connector-base.ts | 19 |
| src/runtime/vdom/vdom-render.ts | 17 |
| src/dev-server/request-handler.ts | 15 |
| src/compiler/prerender/prerender-optimize.ts | 14 |
| src/compiler/sys/stencil-sys.ts | 14 |
| src/sys/node/node-sys.ts | 14 |
| src/compiler/prerender/prerender-queue.ts | 13 |
| src/compiler/sys/in-memory-fs.ts | 13 |
| src/runtime/connected-callback.ts | 13 |
| src/runtime/set-value.ts | 13 |
| src/compiler/output-targets/output-www.ts | 12 |
| src/compiler/transformers/test/parse-vdom.spec.ts | 12 |
| src/compiler/transformers/transform-utils.ts | 12 |
| src/compiler/transpile/transpile-module.ts | 12 |
| src/mock-doc/test/attribute.spec.ts | 12 |
Our most common errors
| Typescript Error Code | Count |
|---|---|
| TS2322 | 362 |
| TS2345 | 344 |
| TS18048 | 204 |
| TS18047 | 82 |
| TS2722 | 37 |
| TS2532 | 24 |
| TS2531 | 21 |
| TS2454 | 14 |
| TS2790 | 11 |
| TS2352 | 10 |
| TS2769 | 8 |
| TS2538 | 8 |
| TS2416 | 7 |
| TS2493 | 3 |
| TS18046 | 2 |
| TS2684 | 1 |
| TS2430 | 1 |
Unused exports report
There are 14 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Unused exports
| File | Line | Identifier |
|---|---|---|
| src/runtime/bootstrap-lazy.ts | 21 | setNonce |
| src/screenshot/screenshot-fs.ts | 18 | readScreenshotData |
| src/testing/testing-utils.ts | 198 | withSilentWarn |
| src/utils/index.ts | 145 | CUSTOM |
| src/utils/index.ts | 269 | normalize |
| src/utils/index.ts | 7 | escapeRegExpSpecialCharacters |
| src/compiler/app-core/app-data.ts | 25 | BUILD |
| src/compiler/app-core/app-data.ts | 115 | Env |
| src/compiler/app-core/app-data.ts | 117 | NAMESPACE |
| src/compiler/fs-watch/fs-watch-rebuild.ts | 123 | updateCacheFromRebuild |
| src/compiler/types/validate-primary-package-output-target.ts | 61 | satisfies |
| src/compiler/types/validate-primary-package-output-target.ts | 61 | Record |
| src/testing/puppeteer/puppeteer-declarations.ts | 485 | WaitForEventOptions |
| src/compiler/sys/fetch/write-fetch-success.ts | 7 | writeFetchSuccessSync |
PR built and packed!Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/8331403965/artifacts/1336185523 If your browser saves files to |
christian-bromann
requested changes
Mar 15, 2024
There was a problem hiding this comment.
I think maybe you missed deleting the html file here
alicewriteswrongs
suggested changes
Mar 15, 2024
|
@alicewriteswrongs Yup! Can't believe I did that 😅 should be fixed in 3b5946e |
alicewriteswrongs
approved these changes
Mar 18, 2024
port the `test/karma/test-app/event-custom-type` test suite to webdriverio. git history has been preserved as much as possible here, using `git mv` to move files from the `karma` dir to `wdio/` in all possible cases. however, git may fail to mark some files as 'moved' if we change a file enough that it exceeds git's "sameness threshold". STENCIL-1191
rwaskiewicz
force-pushed
the
rw/event-custom-wdio-migration
branch
from
3b5946e to
35db1c7
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rwaskiewicz
added a commit
that referenced
this pull request
Mar 18, 2024
fix a build issue where running `npm run build` twice in the `test/wdio`
directory would result in the following failure:
```
[47:48.5] aborted build, 343ms MEM: 359.2MB
[ ERROR ] TypeScript: event-custom-type/cmp.tsx:3:44
Cannot find module '../components' or its corresponding type declarations.
L3: import { EventCustomTypeCustomEvent } from '../components';
[47:48.5] build failed in 343 ms
```
This was introduced in #5493,
where the import statement was not correctly ported over. As a result,
type resolution would fail under `tsconfig.json#moduleResoution` having
a value of 'Node16'
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
fix a build issue where running `npm run build` twice in the `test/wdio`
directory would result in the following failure:
```
[47:48.5] aborted build, 343ms MEM: 359.2MB
[ ERROR ] TypeScript: event-custom-type/cmp.tsx:3:44
Cannot find module '../components' or its corresponding type declarations.
L3: import { EventCustomTypeCustomEvent } from '../components';
[47:48.5] build failed in 343 ms
```
This was introduced in #5493,
where the import statement was not correctly ported over. As a result,
type resolution would fail under `tsconfig.json#moduleResoution` having
a value of 'Node16'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
GitHub Issue Number: N/A
What is the new behavior?
port the
test/karma/test-app/event-custom-typetest suite to webdriverio.git history has been preserved as much as possible here, using
git mvto move files from thekarmadir towdio/in all possible cases. however, git may fail to mark some files as 'moved' if we change a file enough that it exceeds git's "sameness threshold".Documentation
N/A
Does this introduce a breaking change?
Testing
To verify this worked, I made the tests "red" (fail) for every assertion, then one by one made them pass/green
Other information
STENCIL-1191