-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wdio): port key-reorder test suite to wdio #5472
Conversation
|
Path | Error Count |
---|---|
src/dev-server/index.ts | 37 |
src/dev-server/server-process.ts | 32 |
src/compiler/prerender/prerender-main.ts | 22 |
src/testing/puppeteer/puppeteer-element.ts | 22 |
src/runtime/client-hydrate.ts | 20 |
src/screenshot/connector-base.ts | 19 |
src/runtime/vdom/vdom-render.ts | 17 |
src/dev-server/request-handler.ts | 15 |
src/compiler/prerender/prerender-optimize.ts | 14 |
src/compiler/sys/stencil-sys.ts | 14 |
src/compiler/transpile/transpile-module.ts | 14 |
src/sys/node/node-sys.ts | 14 |
src/compiler/prerender/prerender-queue.ts | 13 |
src/compiler/sys/in-memory-fs.ts | 13 |
src/runtime/connected-callback.ts | 13 |
src/runtime/set-value.ts | 13 |
src/compiler/output-targets/output-www.ts | 12 |
src/compiler/transformers/test/parse-vdom.spec.ts | 12 |
src/compiler/transformers/transform-utils.ts | 12 |
src/mock-doc/test/attribute.spec.ts | 12 |
Our most common errors
Typescript Error Code | Count |
---|---|
TS2322 | 361 |
TS2345 | 349 |
TS18048 | 207 |
TS18047 | 82 |
TS2722 | 37 |
TS2532 | 24 |
TS2531 | 21 |
TS2454 | 14 |
TS2790 | 11 |
TS2352 | 10 |
TS2769 | 8 |
TS2538 | 8 |
TS2416 | 6 |
TS2493 | 3 |
TS18046 | 2 |
TS2684 | 1 |
TS2430 | 1 |
Unused exports report
There are 14 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Unused exports
File | Line | Identifier |
---|---|---|
src/runtime/bootstrap-lazy.ts | 21 | setNonce |
src/screenshot/screenshot-fs.ts | 18 | readScreenshotData |
src/testing/testing-utils.ts | 198 | withSilentWarn |
src/utils/index.ts | 145 | CUSTOM |
src/utils/index.ts | 269 | normalize |
src/utils/index.ts | 7 | escapeRegExpSpecialCharacters |
src/compiler/app-core/app-data.ts | 25 | BUILD |
src/compiler/app-core/app-data.ts | 115 | Env |
src/compiler/app-core/app-data.ts | 117 | NAMESPACE |
src/compiler/fs-watch/fs-watch-rebuild.ts | 123 | updateCacheFromRebuild |
src/compiler/types/validate-primary-package-output-target.ts | 61 | satisfies |
src/compiler/types/validate-primary-package-output-target.ts | 61 | Record |
src/testing/puppeteer/puppeteer-declarations.ts | 485 | WaitForEventOptions |
src/compiler/sys/fetch/write-fetch-success.ts | 7 | writeFetchSuccessSync |
PR built and packed!Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/8298378266/artifacts/1329887617 If your browser saves files to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noting the one funny thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had two components, <key-reorder>
and <key-reorder-root>
, but we were only rendering the <key-reorder-root>
component. So I renamed the existing <key-reorder-root>
component to <key-reorder>
and then deleted this component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
9a27a5d
to
f6e40c5
Compare
f6e40c5
to
152c774
Compare
152c774
to
346aa51
Compare
Also a `await $('#item-4').waitForExist();` in `test/wdio/key-reorder/cmp.test.tsx`, which was contributed in #5472, as the test seemed to be flaky on my machine. The waitForExist help to remove this flakiness.
Also a `await $('#item-4').waitForExist();` in `test/wdio/key-reorder/cmp.test.tsx`, which was contributed in #5472, as the test seemed to be flaky on my machine. The waitForExist help to remove this flakiness.
Also a `await $('#item-4').waitForExist();` in `test/wdio/key-reorder/cmp.test.tsx`, which was contributed in #5472, as the test seemed to be flaky on my machine. The waitForExist help to remove this flakiness.
Also a `await $('#item-4').waitForExist();` in `test/wdio/key-reorder/cmp.test.tsx`, which was contributed in #5472, as the test seemed to be flaky on my machine. The waitForExist help to remove this flakiness.
Also a `await $('#item-4').waitForExist();` in `test/wdio/key-reorder/cmp.test.tsx`, which was contributed in #5472, as the test seemed to be flaky on my machine. The waitForExist help to remove this flakiness.
Porting over the key-reorder test suite from Karma to Wdio
Does this introduce a breaking change?
Testing
This one is pretty straightforward, the only thing was that I realized that we had a component that wasn't being used that I deleted.