chore(test): migrate Karma tests to WebdriverIO #5465

christian-bromann · 2024-03-14T01:20:14Z

This patch migrates:

github-actions · 2024-03-14T01:21:41Z

`--strictNullChecks` error report

Typechecking with --strictNullChecks resulted in 1143 errors on this branch.

That's the same number of errors on main, so at least we're not creating new ones!

reports and statistics

Our most error-prone files

Path	Error Count
src/dev-server/index.ts	37
src/dev-server/server-process.ts	32
src/compiler/prerender/prerender-main.ts	22
src/testing/puppeteer/puppeteer-element.ts	22
src/runtime/client-hydrate.ts	20
src/screenshot/connector-base.ts	19
src/runtime/vdom/vdom-render.ts	17
src/dev-server/request-handler.ts	15
src/compiler/prerender/prerender-optimize.ts	14
src/compiler/sys/stencil-sys.ts	14
src/sys/node/node-sys.ts	14
src/compiler/prerender/prerender-queue.ts	13
src/compiler/sys/in-memory-fs.ts	13
src/runtime/connected-callback.ts	13
src/runtime/set-value.ts	13
src/compiler/output-targets/output-www.ts	12
src/compiler/transformers/test/parse-vdom.spec.ts	12
src/compiler/transformers/transform-utils.ts	12
src/compiler/transpile/transpile-module.ts	12
src/mock-doc/test/attribute.spec.ts	12

Our most common errors

Typescript Error Code	Count
TS2322	362
TS2345	346
TS18048	204
TS18047	82
TS2722	37
TS2532	24
TS2531	21
TS2454	14
TS2790	11
TS2352	11
TS2769	8
TS2416	8
TS2538	8
TS2493	3
TS18046	2
TS2684	1
TS2430	1

Unused exports report

There are 14 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports

File	Line	Identifier
src/runtime/bootstrap-lazy.ts	21	setNonce
src/screenshot/screenshot-fs.ts	18	readScreenshotData
src/testing/testing-utils.ts	198	withSilentWarn
src/utils/index.ts	145	CUSTOM
src/utils/index.ts	269	normalize
src/utils/index.ts	7	escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts	25	BUILD
src/compiler/app-core/app-data.ts	115	Env
src/compiler/app-core/app-data.ts	117	NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts	123	updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts	61	satisfies
src/compiler/types/validate-primary-package-output-target.ts	61	Record
src/testing/puppeteer/puppeteer-declarations.ts	485	WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts	7	writeFetchSuccessSync

github-actions · 2024-03-14T01:22:05Z

PR built and packed!

Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/8443380194/artifacts/1361072641

If your browser saves files to ~/Downloads you can install it like so:

unzip -d ~/Downloads ~/Downloads/stencil-core-4.13.0-dev.1711490124.e02344d.tgz.zip && npm install ~/Downloads/stencil-core-4.13.0-dev.1711490124.e02344d.tgz

christian-bromann · 2024-03-14T04:10:48Z

test/karma/test-app/custom-elements-output-webpack/webpack.config.js

-const { WWW_OUT_DIR } = require('../../constants');
-
-module.exports = {
-  entry: path.resolve(__dirname, 'index.esm.js'),


Does someone know the point of having Webpack involved here? It doesn't seem to do anything other than re-bundling the package and importing it in the browser. I believe we cover this feature with the setup script automatically.

I think @rwaskiewicz is familiar with the basis for the setup -- if it's possible for us to do without it I'm all for it because it's super confusing haha

IIRC, reason for this was two-fold:

to test Stencil could go through the webpack process (this is a regression Stencil had at some point)

To use the dist-custom-elements output target, as opposed to www

christian-bromann · 2024-03-20T18:06:02Z

@rwaskiewicz @tanner-reits any objections to merge?

tanner-reits · 2024-03-20T18:46:00Z

@christian-bromann looks like there are some CI failures

christian-bromann · 2024-03-20T19:09:34Z

looks like there are some CI failures

Addressed them, they sneaked it after the last rebase

rwaskiewicz

For the most part, the changes look good here!

Some of these tests were built specifically for DCE or Webpack regressions/features - with that in mind, I think there's some value in bringing them back.

Previously we kinda hacked this in as a 2 part build - we'd have build.app kick off a Stencil Build that included dist-custom-elements, then we'd have webpack bundle/move the files to the www output directory (build.custom-elements job) so they'd get kicked off by the test runner.

It's all a bit confusing TBH, let me know if you wanna jam on ways we can put this together to be a little more cohesive 😆

test/wdio/package-lock.json

christian-bromann · 2024-03-21T22:48:15Z

Some of these tests were built specifically for DCE or Webpack regressions/features - with that in mind, I think there's some value in bringing them back.

@rwaskiewicz I tracked down the source of the test which was introduced in #3039. From what I can see is that this verifies that the DCE output target provides a defineCustomElement method to register the custom element. I would suggest to tweak the setup script to not run for this test and have the component imported and registered manually and verify that the component can be initialized properly.

I don't think it makes sense anymore to keep Webpack as a dependency for this test stack.

rwaskiewicz · 2024-03-25T17:58:32Z

@christian-bromann

I would suggest to tweak the setup script to not run for this test and have the component imported and registered manually and verify that the component can be initialized properly.

I don't think it makes sense anymore to keep Webpack as a dependency for this test stack.

I think I'd be amenable to that 👍

christian-bromann · 2024-03-25T23:28:14Z

I think I'd be amenable to that 👍

I made changes accordingly. Let me know what you think.

rwaskiewicz

One non-blocking question

rwaskiewicz · 2024-03-26T20:01:17Z

test/wdio/slot-reorder/cmp.test.tsx

+    await browser.waitUntil(async () => {
      return document.querySelector('div.reordered');
    });

    reordered();

    await $('button').click();
-    await browser.waitUntil(() => {
+    await browser.waitUntil(async () => {
      return !document.querySelector('div.reordered');
    });

    ordered();

    await $('button').click();
-    await browser.waitUntil(() => {
+    await browser.waitUntil(async () => {


Does passing an async function to waitUntil do anything special? Or do we not need async on these fns?

I've seen race conditions saying .then is not a function and my assumptions are that this has to do with WebdriverIO. It is on the list of things I'ld like to look into eventually. In the meeting, I am adding this to avoid the race conditions.

christian-bromann requested a review from a team as a code owner March 14, 2024 01:20

christian-bromann requested review from rwaskiewicz and alicewriteswrongs March 14, 2024 01:20

christian-bromann commented Mar 14, 2024

View reviewed changes

christian-bromann added the WDIO Migration label Mar 18, 2024

alicewriteswrongs approved these changes Mar 18, 2024

View reviewed changes

christian-bromann force-pushed the cb/test-migration branch from a76e300 to 2bfa5f1 Compare March 18, 2024 21:08

christian-bromann requested a review from tanner-reits March 18, 2024 22:25

christian-bromann force-pushed the cb/test-migration branch from e836f74 to a7b3cf1 Compare March 20, 2024 18:05

rwaskiewicz requested changes Mar 21, 2024

View reviewed changes

test/wdio/package-lock.json Outdated Show resolved Hide resolved

christian-bromann force-pushed the cb/test-migration branch from 6e7c015 to 4c12edf Compare March 21, 2024 21:11

christian-bromann force-pushed the cb/test-migration branch from 4c12edf to 8fd45a3 Compare March 25, 2024 23:27

christian-bromann requested a review from rwaskiewicz March 25, 2024 23:28

alicewriteswrongs approved these changes Mar 26, 2024

View reviewed changes

christian-bromann force-pushed the cb/test-migration branch from 2878d30 to ba4ee40 Compare March 26, 2024 15:47

rwaskiewicz approved these changes Mar 26, 2024

View reviewed changes

christian-bromann added 6 commits March 26, 2024 14:53

test(wdio): move folders

178278f

rename test file

7addf28

rename test file

7da33c6

rewrite files

0f74078

move files

f43c7f8

rename test file

ccd16e9

christian-bromann added 10 commits March 26, 2024 14:53

migrate tests

0822e33

revert

2a8dd55

update karma

dded49b

fix rebase

f9ee8e6

fix rebase

677e630

fix lint

c0be87e

verify that we can import DCE

7d7d6a5

remove webpack from folder name

df2f2df

revert package-lock changes

f59cfd5

fix tests

5e46a74

christian-bromann force-pushed the cb/test-migration branch from ba4ee40 to 5e46a74 Compare March 26, 2024 21:54

christian-bromann enabled auto-merge March 26, 2024 21:56

christian-bromann added this pull request to the merge queue Mar 26, 2024

Merged via the queue into main with commit d8ab583 Mar 26, 2024
123 checks passed

christian-bromann deleted the cb/test-migration branch March 26, 2024 22:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(test): migrate Karma tests to WebdriverIO #5465

chore(test): migrate Karma tests to WebdriverIO #5465

christian-bromann commented Mar 14, 2024

github-actions bot commented Mar 14, 2024 •

edited

Loading

github-actions bot commented Mar 14, 2024 •

edited

Loading

christian-bromann Mar 14, 2024

alicewriteswrongs Mar 14, 2024

rwaskiewicz Mar 21, 2024

christian-bromann commented Mar 20, 2024

tanner-reits commented Mar 20, 2024

christian-bromann commented Mar 20, 2024

rwaskiewicz left a comment

christian-bromann commented Mar 21, 2024

rwaskiewicz commented Mar 25, 2024

christian-bromann commented Mar 25, 2024

rwaskiewicz left a comment

rwaskiewicz Mar 26, 2024 •

edited

Loading

christian-bromann Mar 26, 2024

chore(test): migrate Karma tests to WebdriverIO #5465

chore(test): migrate Karma tests to WebdriverIO #5465

Conversation

christian-bromann commented Mar 14, 2024

github-actions bot commented Mar 14, 2024 • edited Loading

--strictNullChecks error report

reports and statistics

Unused exports report

github-actions bot commented Mar 14, 2024 • edited Loading

PR built and packed!

christian-bromann Mar 14, 2024

Choose a reason for hiding this comment

alicewriteswrongs Mar 14, 2024

Choose a reason for hiding this comment

rwaskiewicz Mar 21, 2024

Choose a reason for hiding this comment

christian-bromann commented Mar 20, 2024

tanner-reits commented Mar 20, 2024

christian-bromann commented Mar 20, 2024

rwaskiewicz left a comment

Choose a reason for hiding this comment

christian-bromann commented Mar 21, 2024

rwaskiewicz commented Mar 25, 2024

christian-bromann commented Mar 25, 2024

rwaskiewicz left a comment

Choose a reason for hiding this comment

rwaskiewicz Mar 26, 2024 • edited Loading

Choose a reason for hiding this comment

christian-bromann Mar 26, 2024

Choose a reason for hiding this comment

github-actions bot commented Mar 14, 2024 •

edited

Loading

`--strictNullChecks` error report

github-actions bot commented Mar 14, 2024 •

edited

Loading

rwaskiewicz Mar 26, 2024 •

edited

Loading