fix(vite): resolve PURE comment warnings

[rwaskiewicz]

What is the current behavior?

prior to this fix, building a stencil/ionic project using stencil would result in a warning in the console similar to the following:

vite v5.0.0-beta.14 building for production...
node_modules/.pnpm/@[email protected]/node_modules/@stencil/core/internal/client/index.js (3800:17) A comment

"/*@__PURE__*/"

in "node_modules/.pnpm/@[email protected]/node_modules/@stencil/core/internal/client/index.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

GitHub Issue Number: N/A

What is the new behavior?

remove /*@__PURE__*/ comment pragma warnings from vite v5/rollup v4 from a pragma that was applied to a variable assignment that rollup can't understand.

Does this introduce a breaking change?

• Yes
• No

Testing

Manual

1. Check out this branch and build it (npm run clean && npm ci && npm run build)
2. Navigate to line 3800 in the generated internal/client/index.js
3. Observe the pragma is gone
4. Pull down the reproduction case associated with the issue for this PR
5. Run pnpm i within the reproduction case, and build pnpm run build
6. Observe the error reported
7. Open the client/index.js file in the reproduction case to line 3800
8. Manually remove the pragma (reaching parity with the locally built file)
9. pnpm run build - observe no errors

Dev Build

1. Pull down the reproduction case associated with the issue
2. Run pnpm i && pnpm build from the root of the repo
3. Observe the error
4. Install the following dev builds of @ionic/react, @ionic/react-router and ionicons

pnpm i @ionic/[email protected]  @ionic/[email protected] [email protected]

(these packages are build with a Stencil dev build 4.7.0-dev.1699016641.733d6c5)
5. pnpm build again, this time, no error!
6.

Other information

Stencil-996 bug: vite v5 warning

fixes: #5008

[github-actions]

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1391 errors on this branch.

That's the same number of errors on main, so at least we're not creating new ones!

reports and statistics

Our most error-prone files

Path	Error Count
src/dev-server/index.ts	37
src/mock-doc/serialize-node.ts	36
src/dev-server/server-process.ts	32
src/compiler/build/build-stats.ts	27
src/compiler/output-targets/dist-lazy/generate-lazy-module.ts	25
src/compiler/style/test/optimize-css.spec.ts	23
src/testing/puppeteer/puppeteer-element.ts	23
src/compiler/prerender/prerender-main.ts	22
src/runtime/client-hydrate.ts	19
src/screenshot/connector-base.ts	19
src/runtime/vdom/vdom-render.ts	18
src/compiler/config/test/validate-paths.spec.ts	16
src/dev-server/request-handler.ts	15
src/compiler/prerender/prerender-optimize.ts	14
src/compiler/sys/stencil-sys.ts	14
src/compiler/transpile/transpile-module.ts	14
src/runtime/vdom/vdom-annotations.ts	14
src/sys/node/node-sys.ts	14
src/compiler/build/build-finish.ts	13
src/compiler/prerender/prerender-queue.ts	13

Our most common errors

Typescript Error Code	Count
TS2345	418
TS2322	395
TS18048	310
TS18047	101
TS2722	38
TS2532	34
TS2531	23
TS2454	14
TS2352	13
TS2769	10
TS2790	10
TS2538	8
TS2344	5
TS2416	4
TS2493	3
TS18046	2
TS2684	1
TS2488	1
TS2430	1

Unused exports report

There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports

File	Line	Identifier
src/runtime/bootstrap-lazy.ts	21	setNonce
src/screenshot/screenshot-fs.ts	18	readScreenshotData
src/testing/testing-utils.ts	198	withSilentWarn
src/utils/index.ts	145	CUSTOM
src/utils/index.ts	232	resolve
src/utils/index.ts	246	normalize
src/utils/index.ts	7	escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts	25	BUILD
src/compiler/app-core/app-data.ts	115	Env
src/compiler/app-core/app-data.ts	117	NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts	123	updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts	62	satisfies
src/compiler/types/validate-primary-package-output-target.ts	62	Record
src/testing/puppeteer/puppeteer-declarations.ts	485	WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts	7	writeFetchSuccessSync