fix(polyfill): add proper url base to import shim #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL needs absolute address in second part of constructor
mikeysteele
reviewed
May 7, 2020
see PR discussion for details
|
Can someone from the team have a look at this and potentially merge it? It would be fantastic to have a release that works with IE 11 again :) |
|
@adamdbradley |
|
I can confirm this fixes the issue. I was getting white screen of death on newly initialized component library. I made the fix in node_modules/@stencil/core/compiler/stencil.js that is in this PR, rebuilt, and the demo component showed up. Please merge! |
|
@bigfish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL needs absolute address in second part of constructor
This should fix #2397
Hope I found the right place this time ;)