more feedback

stenciljs · Apr 27, 2022 · adb3629 · adb3629
1 parent c395b49
commit adb3629
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/compiler/config/config-utils.ts b/src/compiler/config/config-utils.ts
@@ -66,7 +66,7 @@ const getUserConfigName = (config: d.UnvalidatedConfig, correctConfigName: keyof
   for (const userConfigName of userConfigNames) {
     if (userConfigName.toLowerCase() === correctConfigName.toLowerCase()) {
       if (userConfigName !== correctConfigName) {
-        config.logger?.warn(`config "${userConfigName}" should be "${correctConfigName}"`);
+        config.logger.warn(`config "${userConfigName}" should be "${correctConfigName}"`);
         return userConfigName;
       }
       break;

diff --git a/src/compiler/config/validate-dev-server.ts b/src/compiler/config/validate-dev-server.ts
@@ -32,6 +32,10 @@ export const validateDevServer = (
 
   devServer.address = devServer.address.split('/')[0];
 
+  if (isNumber(flags?.port)) {
+    devServer.port = flags?.port;
+  }
+
   const addressSplit = devServer.address.split(':');
   if (addressSplit.length > 1) {
     if (!isNaN(addressSplit[1] as any)) {
@@ -40,10 +44,6 @@ export const validateDevServer = (
     }
   }
 
-  if (isNumber(flags?.port)) {
-    devServer.port = flags?.port;
-  }
-
   if (devServer.port !== null && !isNumber(devServer.port)) {
     if (devServer.address === 'localhost' || !isNaN(devServer.address.split('.')[0] as any)) {
       devServer.port = 3333;