Error and exit on validator configs that contain only LOW validators
#4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes stellar#4526 This change raises an error when a node is a validator and all of the validators in its config (including itself) are marked `LOW` quality. This represents a misconfiguration because `LOW` quality validators cannot win leader election, and so if every validator is `LOW` quality, then there are no eligible nomination leader.
marta-lokhova
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4526
This change raises an error when a node is a validator and all of the validators in its config (including itself) are marked
LOWquality. This represents a misconfiguration becauseLOWquality validators cannot win leader election. If every validator isLOWquality, then there are no eligible nomination leaders and nomination will stall.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)