Update soroban p21 version to 21.2.2, taking binary-search change. #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a critical update. Stellar-core packages from before this update, if built with rust 1.82, will diverge from the network. They must not be deployed in production validators. Rust 1.82 changed the implementation of binary search in its standard library in a way that soroban observes. This change modifies soroban to use a local copy of binary search that is the same as the one in rust 1.81, so that soroban is no longer sensitive to the difference between 1.81 and 1.82. Existing SDF-built release packages of stellar-core were built with rust 1.81, but it is possible that other builds of stellar-core built after the release of rust 1.82 might exist in the field. These must all update to this change, or later, to avoid diverging from peers built with rust 1.81.
dmkozh
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a critical update. Stellar-core packages from before this update, if built with rust 1.82, will diverge from the network. They must not be deployed in production validators.
Rust 1.82 changed the implementation of binary search in its standard library in a way that soroban observes. This change modifies soroban to use a local copy of binary search that is the same as the one in rust 1.81, so that soroban is no longer sensitive to the difference between 1.81 and 1.82.
Existing SDF-built release packages of stellar-core were built with rust 1.81, but it is possible that other builds of stellar-core built after the release of rust 1.82 might exist in the field. These must all update to this change, or later, to avoid diverging from peers built with rust 1.81.